[AIE2P] add Vaddmac pattern#781
Merged
martien-de-jong merged 2 commits intoaie-publicfrom Mar 9, 2026
Merged
Conversation
F-Stuckmann
requested review from
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
Collaborator
martien-de-jong
left a comment
martien-de-jong
left a comment
There was a problem hiding this comment.
Perhaps do it for AIE2PS too?
Collaborator
Author
|
that's why I didn't merge the PR yet ;) |
F-Stuckmann
force-pushed
the
stuckmann.vaddmac
branch
4 times, most recently
from
2ef1014 to
78f8ec4
Compare
F-Stuckmann
force-pushed
the
stuckmann.vaddmac
branch
from
78f8ec4 to
7ea9342
Compare
|
|
||
| // Instruction Combining: Fuse MUL + ADD -> VADDMAC/VADDMSC | ||
| // When a MAC/MSC result feeds into an ADD(ZeroAddConf), the multiply and | ||
| // both accumulations are performed by a single VADDMAC/VADDMSC instruction. |
Collaborator
There was a problem hiding this comment.
nit: I think we replace an add with zero by a true add. Hence there are no two accumulations.
martien-de-jong
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single performance regression we are seing is caused by a MOV instruction to satisfy the dst == src0 requirement inside of a loop.