[AIEX] Unified Opcodes across Subtargets#766
Conversation
F-Stuckmann
force-pushed
the
stuckmann.unified.opcodes
branch
2 times, most recently
from
9f95beb to
f3268ce
Compare
F-Stuckmann
requested review from
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
| // Indicates if this instruction is shared across AIE targets and should be | ||
| // placed in a stable enum layer (Layer 2) between target-defined generics | ||
| // and target-specific instructions. | ||
| bit isAIEShared = false; |
There was a problem hiding this comment.
You can't refer to AIE in this file.
| @@ -60,6 +60,7 @@ let InOperandList = (ins type2:$val, type0:$base, type1:$modifier, type1:$size1, | |||
| // after extracting the element from a vector. This gMIR is added | |||
| // to avoid zero extending smaller size elements (S8, S16) to S32 | |||
| def G_AIE_ZEXT_EXTRACT_VECTOR_ELT : AIEGenericInstruction { | |||
| let AccessorMethod = "getGenericZExtExtractVectorEltOpcode"; | |||
There was a problem hiding this comment.
Since we have unified the enumerations wrt generic opcodes, can't we just use the different namespaces interchangeably without ever using these accessors? The existing getGenericZExtExtractVectorEltOpcode() is obsolescent, and will in due time be replaced with the equivalent AIE::G_ZEXT_EXTRACT_ELT (or whatever).
Later we can even remove the generic opcodes from the specific enums.
F-Stuckmann
force-pushed
the
stuckmann.unified.opcodes
branch
from
f3268ce to
f6f9a81
Compare
mludevid
left a comment
mludevid
left a comment
There was a problem hiding this comment.
Would it be possible to share the definitions of the instructions? As in instead of making sure that they are defined in all AIE targets centralize the definition and all targets include that central definition. We can still keep the check to make sure we didn't miss anything.
There was a problem hiding this comment.
Maybe move this to the next commit? Keep this as an aligning opcodes between targets commit and then in the next one add the checks that enforce this.
3 participants
Unify Opcodes so that we now work on generic opcodes.
@martien-de-jong I think we could also move the legalizer into tablegen.