[AIE] Fix dereferencing an unengaged std::optional<int>.#744
Open
SagarMaheshwari99 wants to merge 1 commit intoaie-publicfrom
Open
[AIE] Fix dereferencing an unengaged std::optional<int>.#744SagarMaheshwari99 wants to merge 1 commit intoaie-publicfrom
SagarMaheshwari99 wants to merge 1 commit intoaie-publicfrom
Conversation
SagarMaheshwari99
requested review from
F-Stuckmann,
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
SagarMaheshwari99
force-pushed
the
sagarm/fix.deref
branch
from
4720729 to
1016fa7
Compare
niwinanto
reviewed
Dec 19, 2025
| *TII->getFirstMemoryCycle(FixedDepMI->getDesc().SchedClass) + 1, | ||
| Latency)); | ||
| } else if (TII->isLock(FixedDepMI->getOpcode())) { | ||
| auto OptFirstMemCycle = |
niwinanto
reviewed
Dec 19, 2025
| Latency)); | ||
| } else if (TII->isLock(FixedDepMI->getOpcode())) { | ||
| auto OptFirstMemCycle = | ||
| TII->getFirstMemoryCycle(FixedDepMI->getDesc().SchedClass); |
Collaborator
There was a problem hiding this comment.
Also, would be nice to know which SchedClass does not get this info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.