[DRAFT] [AIEX] simplify Debug types across AIE architectures#670
Closed
F-Stuckmann wants to merge 1 commit intoaie-publicfrom
Closed
[DRAFT] [AIEX] simplify Debug types across AIE architectures#670F-Stuckmann wants to merge 1 commit intoaie-publicfrom
F-Stuckmann wants to merge 1 commit intoaie-publicfrom
Conversation
F-Stuckmann
requested review from
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto and
stephenneuendorffer
as code owners
andcarminati
reviewed
Oct 1, 2025
| #include "llvm/CodeGen/MachineDominators.h" | ||
| #include "llvm/InitializePasses.h" | ||
|
|
||
| #define DEBUG_TYPE "aie2-postlegalizer-custom-combiner" |
Collaborator
There was a problem hiding this comment.
I guess this problematic because we use this as the pass name. If we decouple the debug from the pass name it could be fine.
Collaborator
There was a problem hiding this comment.
See INITIALIZE_PASS_BEGIN. We register two passes with the same name.
Collaborator
Author
There was a problem hiding this comment.
yeah, but i also don't like a different pass name and a different debug type.
F-Stuckmann
changed the title
niwinanto
reviewed
Oct 2, 2025
| #include "llvm/InitializePasses.h" | ||
|
|
||
| #define DEBUG_TYPE "aie2-postlegalizer-custom-combiner" | ||
| #define DEBUG_TYPE "postlegalizer-custom-combiner" |
Collaborator
There was a problem hiding this comment.
Do you want to retain the aie keyword
Collaborator
Author
|
properly fixed in #828 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.