Skip to content

Conversation

@llr891011
Copy link

learn

Amit Sunil Dhamne and others added 30 commits October 15, 2020 20:12
… node start

Invalidate child nodes of a PLD when new RM corresponding to it
is run. This is because the topology of the PLD's children is no
longer valid and subject to change. As part of invalidation, the
node is removed from tree and links (such as Parent, Child  &
NextPeer) set to NULL. This is done at init node start phase since
that's the first command to run when an RM is loaded

Signed-off-by: Amit Sunil Dhamne <amit.sunil.dhamne@xilinx.com>

Acked-for-series: Izhar Ameer Shaikh <izhar.ameer.shaikh@xilinx.com>
PLDs are created by pm_add_node cmd present in static image or
RM. Currently if same RM is run, PM errors out as PLD corresponding
to a nodeid is already present in database. However, we should
allow this operation since re-running same RM is valid.

This change is to allow addition of duplicate add node cmds
without erroring out. This change optimizes memory in case
the nodeid passed has an entry in database without allocating
new memory. Re-addition for PLD0 is illegal as PLD0 represents
static image and added as part of topology CDO

Signed-off-by: Amit Sunil Dhamne <amit.sunil.dhamne@xilinx.com>

Acked-for-series: Izhar Ameer Shaikh <izhar.ameer.shaikh@xilinx.com>
As part of Add Node Parent API, nodeid of PLD and the nodeid
of parent PLD args are passed. In code PLDs are represented
as multi-level linkedlist, that has only one root node (PLD0).
Add check to make sure Parent Node (if valid), PLD's parent
is not NULL. This will help prevent creation of broken trees as
there are uninitialized nodes present in database

Signed-off-by: Amit Sunil Dhamne <amit.sunil.dhamne@xilinx.com>

Acked-for-series: Izhar Ameer Shaikh <izhar.ameer.shaikh@xilinx.com>
Scanf is expected to read data from stdin. For that to happen, __read
needs to be customized in IAR port to always read data from stdin.

Signed-off-by: Mubin Usman Sayyed <mubin.usman.sayyed@xilinx.com>
Acked-by: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
This patch fix following violation
"misra_c_2012_rule_8_4_violation:Object definition does not
 have a visible prototype"

Fixed this violation by keeping the variable declaration in the header file.

Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>

Acked-for-series: Srinivas Goud <srinivas.goud@xilinx.com>
This patch fix following violation
"misra_c_2012_rule_10_3_violation:Implicit conversion from
 essential type to different or narrower essential type "signed 32-bit int"

Fixed this violation across the driver by explicitly typecasting at all the
required/intended places.

Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>

Acked-for-series: Srinivas Goud <srinivas.goud@xilinx.com>
This patch fix following violation
"misra_c_2012_rule_10_6_violation:Assigning composite expression of
 width 32 to a target of width 64"

Fixed this violation across the driver files by changing the type.

Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>

Acked-for-series: Srinivas Goud <srinivas.goud@xilinx.com>
This patch fix following violation
"misra_c_2012_rule_10_4_violation:Essential type of the left hand
 operand(float) is not the same as that of the right operand(unsigned)"

Fixed this violation by adding "U" to unsigned integer constants at all
required places.

Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>

Acked-for-series: Srinivas Goud <srinivas.goud@xilinx.com>
This patch fix following violation
"misra_c_2012_directive_4_5_violation:Declaration with identifier
 "FuncPtr", which is ambiguous"

Fixed this violation by changing the funciton argument name.

Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>

Acked-for-series: Srinivas Goud <srinivas.goud@xilinx.com>
To maintain common signature in all drivers removing const keyword.

Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>

Acked-for-series: Srinivas Goud <srinivas.goud@xilinx.com>
Updated changelog file for rtcpsu driver.

Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>

Acked-for-series: Srinivas Goud <srinivas.goud@xilinx.com>
Driver should only check the datapath mode for Gen 3 devices.

Signed-off-by: Conall O'Griofa <conall.o'griofa@xilinx.com>
Acked-by: Anand Ashok Dumbre <anandash@xilinx.com>
… to typecast Dp subsystem pointer

Updated the Dprx_InterruptHandlerPayloadAlloc() in MST PT application to typecast Dp Subsystem pointer

Signed-off-by: nishantd <nishant.dhonde@xilinx.com>

Acked by: Kapil Usgaonkar<kapil.usgaonkar@xilinx.com>
When AXI IIC is used as slave, NAAS interrupt is used to recognize
the end of current transaction. In high traffic master-slave communication
with slow slave response, there is a chance of AAS and 1 byte received
in FIFO even before NAAS interrupt handler is completed. If the
flushing of RxFIFO happens, the one byte of next transaction is lost.

To avoid this, flush the RxFIFO only after checking the status of
controller.

Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Acked-by: Srinivas Goud <srinivas.goud@xilinx.com>
MISRA C Directive 4.7 States: If a function returns error information, then that error information shall be tested

This patch fixes MISRA C Directive 4.7 violation by checking for return statements for XST_SUCCESS/XST_FAILURE from functions.

Signed-off-by: Tarun DTS <tarun.dts@xilinx.com>

Acked-for-series: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
MISRA C Rule 10.1 States: Operands shall not be of an inappropriate essential type

This patch fixes MISRA C Rule 10.1 violation by using the proper type variables where required or typecasting if necessary

Signed-off-by: Tarun DTS <tarun.dts@xilinx.com>

Acked-for-series: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
MISRA C Rule 10.3 States: The value of an expression shall not be assigned to an
object with a narrower essential type or of a different essential type category

This patch fixes MISRA C Rule 10.3 violation by using the proper type variables
where required or typecasting if necessary

Signed-off-by: Tarun DTS <tarun.dts@xilinx.com>

Acked-for-series: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
MISRA C Rule 10.4 States: Both operands of an operator in which the usual
arithmetic conversionsare performed shall have the same essential type category

This patch fixes MISRA C Rule 10.4 violation by using the same type variable
for both operands where possible

Signed-off-by: Tarun DTS <tarun.dts@xilinx.com>

Acked-for-series: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
MISRA C Rule 10.6 States: The value of a composite expression shall not
be assigned to an object with wider essential type

This patch fixes MISRA C Rule 10.6 violation by using the same type
variables for composite expression

Signed-off-by: Tarun DTS <tarun.dts@xilinx.com>

Acked-for-series: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
MISRA C Rule 10.7 States: If a composite expression is used as one operand
of an operator in which the usual arithmetic conversions are performed then
the other operand shall not have wider essential type

This patch fixes MISRA C Rule 10.7 violation by using the same type variable types for both
operands in an arithmetic expression

Signed-off-by: Tarun DTS <tarun.dts@xilinx.com>

Acked-for-series: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
MISRA C Rule 11.9 States: The macro NULL shall be the only permitted
form of integer null pointer constant

This patch fixes MISRA C Rule 11.9 violation by using NULL instead of
0U for null poitner

Signed-off-by: Tarun DTS <tarun.dts@xilinx.com>

Acked-for-series: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
MISRA C Rule 12.2 States: The right hand operand of a shift operator shall
lie in the range zero to one less than the width in bits of the essential
type of the left hand operand

This patch fixes MISRA C Rule 12.2 violation by casting constants with higher
type when shifting more than 7 bits

Signed-off-by: Tarun DTS <tarun.dts@xilinx.com>

Acked-for-series: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
MISRA C Rule 13.2 States: The value of an expression and its persistent side effects
shall be the same under all permitted evaluation orders

This patch fixes MISRA C Rule 13.2 violation by using separate statements for function calls
which include volatile variable access

Signed-off-by: Tarun DTS <tarun.dts@xilinx.com>

Acked-for-series: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
For HD mode, bit 4 and 7 of byte 3 (bit 23 and 20) of ST352
payload determine the colorimetry per SMPTE 292-1:2018 Sec 9.5.

The same thing is observed with Phabrix Qx for 3GB mode with payload
0x8A.

Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com>

Acked-for-series: Sandip Kothari <sandipk@xilinx.com>
There is a possibility that incoming video stream parameters like EOTF
function can change on the fly without the video getting unlocked
and then locked again.

This patch handles such a scenario by checking the incoming stream's
ST352 payload against older value on vsync interrupt and updating
the stream's parameters like format, frame rate and EOTF.

A new interrupt handler is added for Vsync interrupt

Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com>

Acked-for-series: Sandip Kothari <sandipk@xilinx.com>
This patch adds support for the new Vsync handler.

Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com>

Acked-for-series: Sandip Kothari <sandipk@xilinx.com>
Fix no video output on changing resolution by updating the canonical definitions of UART

Signed-off-by: Shruti Gupta <shruti.gupta@xilinx.com>

Acked by: Kapil Usgaonkar<kapil.usgaonkar@xilinx.com>
New APIs will enable user to configure thresholds for
temperature and voltages

Signed-off-by: Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
New APIs will allow user to set alarm config and alarm modes

Signed-off-by: Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
The new interrupt handling structure allows user to set
individual callbacks for individual supply and temperature
alarms

Signed-off-by: Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
tejus26 and others added 20 commits November 7, 2020 04:32
use unsigned char data type to access individual bytes for unaligned
memory access.
Without this, if the unaligned data is signed value, the sign extension
will corrupt the data before writing to the data memory.

Signed-off-by: Tejus Siddagangaiah <tejus.siddagangaiah@xilinx.com>
Acked-by: Wendy Liang <wendy.liang@xilinx.com>
updated for addtogroup avbuf

Signed-off-by: Meena Paleti <meena.paleti@xilinx.com>

Acked-by : Siva Prasad Addepalli<sivaprasad.addepall@xilinx.com>
Updated changelog for axipcie

Signed-off-by: Meena Paleti <meena.paleti@xilinx.com>

Acked-by : Siva Addepalli<saddepal@xilinx.com>
This patch changes device names referenced within the code to match the
external device names.

Signed-off-by: Nicole Baze <nicole.baze@xilinx.com>

Acked-for-series: Izhar Ameer Shaikh <izhar.ameer.shaikh@xilinx.com>
This patch changes the device names referenced within the code to match
the external device names.

Signed-off-by: Nicole Baze <nicole.baze@xilinx.com>

Acked-for-series: Izhar Ameer Shaikh <izhar.ameer.shaikh@xilinx.com>
This patch fixes the below issues in encrypted boot:
 - Initializes Global Variation Filter in PufData structure to TRUE. This will fix
PUF regeneration failure at PLM due to GVF mismatch.

 - Forces DpaCmCfg back to the value read from the PDI after comparison with EfuseDpaCm value.
This will fix invalid input error for DPACM disabled boards.

Signed-off-by: Harsha <harsha.harsha@xilinx.com>
Acked-by: Ramakrishna Ganeshu Poolla <ramakrishna.ganeshu.poolla@xilinx.com>
BSP changelog updated with standalone 7.3 updates.

Signed-off-by: Mubin Usman Sayyed <mubin.usman.sayyed@xilinx.com>
Acked-by: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
- ImageSelector was checking for a different string and not "ABUM"
as identification string. The check was failing and Image Selector
did a soft reset and CSU ROM booted the next available image,
which was always ImageA irrespective of the values of
persistent registers The patch rectifies the issue by checking the
identification string with "ABUM"

- The patch rectifies the checksum calculation logic by calculating
checksum on the first 8 words of persistent register space

Signed-off-by: Anantha Umapathi <anantha.umapathi@xilinx.com>
Acked-by: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
Updated for changelog cframe and others

Signed-off-by: Meena Paleti <meena.paleti@xilinx.com>

Acked-by : Siva Addepalli<saddepal@xilinx.com>
New rules include:
- if distributing full rate clock, the souece tile must be a centre tile
  (ADC 1,2 or DAC 1,2)
- no division of full rate clock
- Full rate clock can not be passed from ADC to ADC

Signed-off-by: Conall O'Griofa <conall.o'griofa@xilinx.com>
Acked-by: Matthew Roche <mroche@xilinx.com>
New rules include:
- if distributing full rate clock, the souece tile must be a centre tile
  (ADC 1,2 or DAC 1,2)
- no division of full rate clock
- Full rate clock can not be passed from ADC to ADC

Signed-off-by: Conall O'Griofa <conall.o'griofa@xilinx.com>
Acked-by: Matthew Roche <mroche@xilinx.com>

Acked-by : Siva Addepalli<saddepal@xilinx.com>
This patch fixes the issue by masking SSS register with corresponding inputsrc mask value instead of enum value

Signed-off-by: Praveen Teja Kundanala <praveen.teja.kundanala@xilinx.com>
Acked-by: Sarat Chand Savitala <sarat.chand.savitala@xilinx.com>
The patch updates the text on GUI of image recovery to make it more generic.

Signed-off-by: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
Acked-by: Mohan Marutirao Dhanawade <mohan.dhanawade@xilinx.com>
… folder

The patch checks in latest web.img which has changes corresponding to renaming of variables
in index.js and index.htm

Signed-off-by: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>

Acked-by: Mohan Marutirao Dhanawade <mohan.dhanawade@xilinx.com>
The patch updates text on Vitis GUI and image recovery webpage GUI to
make the app more generic.

Signed-off-by: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
Acked-by: Mohan Marutirao Dhanawade <mohan.dhanawade@xilinx.com>
… libraries

Signed-off-by: Siva Addepalli <sivaprasad.addepalli@xilinx.com>
Signed-off-by: Siva Addepalli <sivaprasad.addepalli@xilinx.com>
This patch adds support for versionless build support for PSMFW for
2020.2 release.

Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
Acked-by: Nicole Baze <nicole.baze@xilinx.com>
There is a warning for "omitting copy of directory" as -r option was
not used. As such there is no need to copy subdirectory, but to avoid
warning use "cp -r".

Signed-off-by: Ravi Patel <ravi.patel@xilinx.com>
Acked-by: Amanda Nicole Baze <nicole.baze@xilinx.com>
@vsrik
Copy link
Contributor

vsrik commented May 9, 2022

hi @llr891011 - what is this PR for ? It says learn ? We donot accept any PRs , if you have anyspecific fix then please send the patch to git@amd.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.