Update try-catch block to give a more descriptive message when buffer allocation fails#76
Merged
Merged
Conversation
…n allocation fails Signed-off-by: snigupta <snigupta@amd.com>
jvillarre
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When device buffer allocation fails, a std::bad_alloc is thrown which was previously caught only by a generic catch (...) that printed misleading warning "AIE trace is currently not supported on this platform". This message is incorrect for buffer allocation failure: the platform supports AIE trace; allocation failed due to insufficient device/CMA memory.
Solution
Add a dedicated catch (const std::bad_alloc&) before the existing catch (...) in AieTracePluginUnified::updateAIEDevice and report the existing allocation-failure warning. The generic catch (...) remains for other unexpected failures and still emits the platform “not supported” message.
Testing
Tested on VCK190 which now displays the correct warning message