Apply fixes to enable system_timeline in hw_context flows#75
Open
predutta wants to merge 1 commit into
Open
Conversation
Signed-off-by: predutta <predutta@amd.com>
There was a problem hiding this comment.
Pull request overview
Enables generation of the AIE “system timeline” timestamps output for hw_context / register_xclbin flows in addition to the existing load_xclbin flow, addressing cases where aie_event_timestamps.bin was not produced and SystemTimeline generation failed.
Changes:
- Remove the restriction that system timeline is only enabled for
LOAD_XCLBIN_STYLE. - Enable system timeline whenever the INI flag is set and the design is single-partition (based on partition overlay metadata).
- Update the inline comment to reflect the broadened supported flows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables AIE system timeline for both hw_context flows and Vitis load-xclbin flows.
CR [1270630]: aie_event_timestamps.bin no longer generated when host code uses hw_context API, causing SystemTimeline generation failure
The fix has been tested on vek280 (aie2).