Add getAppStyleHAL() callback to the HAL device-offload plugin#73
Open
meghnakon wants to merge 1 commit into
Open
Add getAppStyleHAL() callback to the HAL device-offload plugin#73meghnakon wants to merge 1 commit into
meghnakon wants to merge 1 commit into
Conversation
Signed-off-by: meghnakon <meghnak@xsjmeghnak40x.amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the current XDP AppStyle (LOAD_XCLBIN vs REGISTER_XCLBIN) so the XRT shim layer can check which application flow XDP was configured for.
Currently, the shim destructor unconditionally invokes the device-offload flush, but in the REGISTER_XCLBIN flow the plugin expects a hw_context_impl* and receives a xocl::shim* instead, causing a segfault on application exit. Exposing the AppStyle lets the shim safely skip that duplicate flush, since the hw_context_impl destructor already handles it correctly.
CR-1269493