Skip to content

Added Warning in ML Timeline plugin if no microcontroller section in aie trace metadata #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garimadhaked wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Warning in ML Timeline plugin if no microcontroller section in aie trace metadata #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions profile/plugin/ml_timeline/clientDev/ml_timeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@ namespace xdp {
xrt_core::message::send(xrt_core::message::severity_level::debug, "XRT", numSegmentMsg.str());
}

/* Skip buffer creation when size is 0 (e.g. AIE trace metadata present but no microcontroller section). */
if (mBufSz == 0 || mNumBufSegments == 0) {
xrt_core::message::send(xrt_core::message::severity_level::debug, "XRT",
"ML Timeline skipped: result buffer size is 0 (no microcontroller section). Cannot get ML Timeline info.");
return;
}

try {

/* Use a container for Debug BO for results to control its lifetime.
Expand Down
6 changes: 6 additions & 0 deletions profile/plugin/ml_timeline/ve2/ml_timeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,12 @@ namespace xdp {
xrt_core::message::send(xrt_core::message::severity_level::debug, "XRT", numSegmentMsg.str());
}

/* Skip buffer creation when size is 0 (e.g. AIE trace metadata present but no microcontroller section). */
if (mBufSz == 0 || mNumBufSegments == 0) {
xrt_core::message::send(xrt_core::message::severity_level::debug, "XRT",
"ML Timeline skipped: result buffer size is 0 (no microcontroller section). Cannot get ML Timeline info.");
return;
}
try {
mResultBOHolder = std::make_unique<xdp::ResultBOContainer>(hwCtxImpl, mBufSz);
memset(mResultBOHolder->map(), 0, mBufSz);
Expand Down