fix(opencode): normalize windows path separators in memory path parsing#912
Open
hzhongzhong wants to merge 1 commit into
Open
fix(opencode): normalize windows path separators in memory path parsing#912hzhongzhong wants to merge 1 commit into
hzhongzhong wants to merge 1 commit into
Conversation
parsePath/parseCcPath matched a forward-slash-only regex, but buildPath composes paths with path.join() which emits backslashes on Windows. As a result every memory file was rejected with "path outside memory layout" and the memory system never loaded, causing per-session amnesia on Windows. Normalize backslashes to forward slashes before matching. Fixes XiaomiMiMo#908 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #908
Problem
On Windows the memory system rejects every file with "path outside memory layout" and never loads, so the agent loses all context between sessions.
parsePath/parseCcPathinmemory/paths.tsmatch a forward-slash-only regex, butbuildPathcomposes paths withpath.join(), which emits backslashes on Windows — so the regex never matches and every locator comes back null.Fix
Normalize backslashes to forward slashes before matching, in both parsers.
Verification
Added Windows backslash cases to
test/memory/paths.test.tsandcc-paths.test.ts(fail before, pass after).Ran
bun test test/memory test/tool/memory-path-guard.test.ts→ 133 pass, 0 fail.