fix(clipboard): warn on missing clipboard tools instead of silent failure#897
Open
hiwujie wants to merge 1 commit into
Open
fix(clipboard): warn on missing clipboard tools instead of silent failure#897hiwujie wants to merge 1 commit into
hiwujie wants to merge 1 commit into
Conversation
…lure On Linux, when no native clipboard tool (xclip/xsel/wl-copy) is found, log a clear warning with install instructions instead of silently failing. Also warn about tmux allow-passthrough requirement for OSC 52. Fixes XiaomiMiMo#188
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Ubuntu and other Linux distros (including UOS),
copysilently fails -- the UI shows "copied to clipboard" but nothing is actually copied.The clipboard fallback chain:
wl-copy/xclip/xsel-- missing on minimal installsclipboardynpm package -- depends on xclip/xsel, also fails silentlyResult:
.catch(() => {})swallows all errors, user sees success toast, clipboard is empty.Fix
Two small changes to
clipboard.ts:1.
getCopyMethod-- warn when no native clipboard tool is found on LinuxAfter trying wl-copy, xclip, xsel and all missing, log a clear warning with install instructions.
2.
writeOsc52-- warn about tmuxallow-passthroughWhen running inside tmux, log a reminder that OSC 52 requires
set -g allow-passthrough on.Why this approach
TERM_PROGRAM === "xterminal")Related