fix: normalize path separators in memory path parsing for Windows (#861), replace console.* with structured logging#864
Open
MrRealORG wants to merge 1 commit into
Conversation
…aomiMiMo#861), replace console.* with structured logging in TUI - Add normalizeSeparators() to parsePath() and parseCcPath() so backslash paths produced by path.join on Windows are correctly matched by the forward-slash regexes (fixes XiaomiMiMo#861) - Harden assertSafeComponent() to split on both / and \ and reject leading backslash, preventing Windows-style path traversal - Replace 2 console.error calls in dialog-mcp.tsx with Log.Default.warn/error - Replace 1 console.log in prompt/index.tsx with Log.Default.error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #861 — on Windows,
path.joinproduces backslash-separated paths (C:\xxx\memory\global\MEMORY.md), but the regexes inparsePath()andparseCcPath()only match forward slashes, causing all memory files to be skipped with"path outside memory layout, skipping".Also replaces 3 remaining
console.*calls in TUI components with structured logging.Changes (3 files)
packages/opencode/src/memory/paths.ts— AddnormalizeSeparators()helper that converts\to/before regex matching in bothparsePath()andparseCcPath(). HardenassertSafeComponent()to split on both/and\and reject leading backslashes, preventing Windows-style path traversal.packages/opencode/src/cli/cmd/tui/component/dialog-mcp.tsx— Replace 2console.errorcalls withLog.Default.warn/Log.Default.error(addLogimport from@/util).packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx— Replace 1console.logwithLog.Default.error(addLogimport from@/util).