pbkit: deduplicate defines #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pionere
commented
Aug 20, 2025
pionere
commented
- get rid of defines in pbkit.c which are defined in pblit_dma.h (included via pbkit.h)
- get rid of defines in pbkit.c which are defined in pblit_dma.h (included via pbkit.h)
abaire
reviewed
Aug 25, 2025
Contributor
abaire
left a comment
abaire
left a comment
There was a problem hiding this comment.
lgtm, I apparently failed to push this change with my previous cleanup PRs.
Member
|
nit: Commit name / description isn't exactly our style |
Contributor
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.