Skip to content

Small warning cleanup #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GXTX wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Small warning cleanup #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e4438b
meta: Cleanup strict-prototypes warnings
GXTX Apr 24, 2025
c8b0e18
xboxkrnl: STATUS_* needs to be NTSTATUS not DWORD
GXTX Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/hal/fileio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ static void setPartitionString(char c, char *string)
partitions[i] = string;
}

static char *getCurrentDirString()
static char *getCurrentDirString(void)
{
char *tmp;
if (currentDirString) {
Expand Down
6 changes: 3 additions & 3 deletions lib/hal/video.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ void XVideoSetGammaRamp(unsigned int offset, const GAMMA_RAMP_ENTRY *entries, un
}


void XVideoWaitForVBlank()
void XVideoWaitForVBlank(void)
{
if (! IsrRegistered) {
if (InstallVBLInterrupt())
Expand All @@ -489,12 +489,12 @@ void XVideoWaitForVBlank()
VIDEOREG(PCRTC_INTR)=PCRTC_INTR_VBLANK_RESET;
}

unsigned char* XVideoGetVideoBase()
unsigned char* XVideoGetVideoBase(void)
{
return (unsigned char *)VIDEO_BASE;
}

int XVideoVideoMemorySize()
int XVideoVideoMemorySize(void)
{
// TODO Is this always the case?
// 4MB
Expand Down
2 changes: 1 addition & 1 deletion lib/hal/xbox.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

#define LaunchDataPageSize 0x1000

void XReboot()
void XReboot(void)
{
HalReturnToFirmware(HalRebootRoutine);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/net/nvnetdrv/nvnetdrv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ static void nvnetdrv_handle_irq (void)
}


const uint8_t *nvnetdrv_get_ethernet_addr ()
const uint8_t *nvnetdrv_get_ethernet_addr (void)
{
return g_ethAddr;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/nxdk/configsector.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ _Static_assert(sizeof(nxdk_network_config_sector_t) == NXDK_CONFIG_DATA_SIZE, "n
#define NXDK_NETWORK_CONFIG_HEADERV2 'XBV2'
#define NXDK_NETWORK_CONFIG_FOOTER 'XBCP'

HANDLE nxOpenConfigPartition ()
HANDLE nxOpenConfigPartition(void)
{
ANSI_STRING str;
RtlInitAnsiString(&str, "\\Device\\Harddisk0\\partition0");
Expand Down
2 changes: 1 addition & 1 deletion lib/nxdk/net.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ int nxNetInit(const nx_net_parameters_t *parameters)
return 0;
}

int nxNetShutdown()
int nxNetShutdown(void)
{
return 0;
}
2 changes: 1 addition & 1 deletion lib/nxdk/net.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ typedef struct nx_net_parameters_t_
* @return 0 on success, negative values indicate various errors.
*/
int nxNetInit(const nx_net_parameters_t *parameters);
int nxNetShutdown();
int nxNetShutdown(void);

#ifdef __cplusplus
}
Expand Down
2 changes: 1 addition & 1 deletion lib/winapi/tls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#include <windows.h>

DWORD TlsAlloc ()
DWORD TlsAlloc (void)
{
return FlsAlloc(NULL);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/winapi/winmm/timeapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ MMRESULT timeEndPeriod (UINT uPeriod)
return TIMERR_NOERROR;
}

DWORD timeGetTime ()
DWORD timeGetTime (void)
{
return KeTickCount;
}
140 changes: 70 additions & 70 deletions lib/xboxkrnl/ntstatus.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,76 +10,76 @@

#include "xboxdef.h"

#define STATUS_SUCCESS ((DWORD)0x00000000L)
#define STATUS_WAIT_0 ((DWORD)0x00000000L)
#define STATUS_ABANDONED_WAIT_0 ((DWORD)0x00000080L)
#define STATUS_USER_APC ((DWORD)0x000000C0L)
#define STATUS_ALERTED ((DWORD)0x00000101L)
#define STATUS_TIMEOUT ((DWORD)0x00000102L)
#define STATUS_PENDING ((DWORD)0x00000103L)
#define STATUS_OBJECT_NAME_EXISTS ((DWORD)0x40000000L)
#define STATUS_NO_YIELD_PERFORMED ((DWORD)0x40000024L)
#define STATUS_SEGMENT_NOTIFICATION ((DWORD)0x40000005L)
#define STATUS_GUARD_PAGE_VIOLATION ((DWORD)0x80000001L)
#define STATUS_DATATYPE_MISALIGNMENT ((DWORD)0x80000002L)
#define STATUS_BREAKPOINT ((DWORD)0x80000003L)
#define STATUS_SINGLE_STEP ((DWORD)0x80000004L)
#define STATUS_BUFFER_OVERFLOW ((DWORD)0x80000005L)
#define STATUS_NO_MORE_FILES ((DWORD)0x80000006L)
#define STATUS_NO_MORE_ENTRIES ((DWORD)0x8000001AL)
#define STATUS_UNSUCCESSFUL ((DWORD)0xC0000001L)
#define STATUS_ACCESS_VIOLATION ((DWORD)0xC0000005L)
#define STATUS_IN_PAGE_ERROR ((DWORD)0xC0000006L)
#define STATUS_INVALID_HANDLE ((DWORD)0xC0000008L)
#define STATUS_INVALID_PARAMETER ((DWORD)0xC000000DL)
#define STATUS_END_OF_FILE ((DWORD)0xC0000011L)
#define STATUS_NO_MEMORY ((DWORD)0xC0000017L)
#define STATUS_ILLEGAL_INSTRUCTION ((DWORD)0xC000001DL)
#define STATUS_ALREADY_COMMITTED ((DWORD)0xC0000021L)
#define STATUS_ACCESS_DENIED ((DWORD)0xC0000022L)
#define STATUS_BUFFER_TOO_SMALL ((DWORD)0xC0000023L)
#define STATUS_OBJECT_TYPE_MISMATCH ((DWORD)0xC0000024L)
#define STATUS_NONCONTINUABLE_EXCEPTION ((DWORD)0xC0000025L)
#define STATUS_INVALID_DISPOSITION ((DWORD)0xC0000026L)
#define STATUS_OBJECT_NAME_INVALID ((DWORD)0xC0000033L)
#define STATUS_OBJECT_NAME_NOT_FOUND ((DWORD)0xC0000034L)
#define STATUS_OBJECT_NAME_COLLISION ((DWORD)0xC0000035L)
#define STATUS_OBJECT_PATH_NOT_FOUND ((DWORD)0xC000003AL)
#define STATUS_MUTANT_NOT_OWNED ((DWORD)0xC0000046L)
#define STATUS_SEMAPHORE_LIMIT_EXCEEDED ((DWORD)0xC0000047L)
#define STATUS_ARRAY_BOUNDS_EXCEEDED ((DWORD)0xC000008CL)
#define STATUS_FLOAT_DENORMAL_OPERAND ((DWORD)0xC000008DL)
#define STATUS_FLOAT_DIVIDE_BY_ZERO ((DWORD)0xC000008EL)
#define STATUS_FLOAT_INEXACT_RESULT ((DWORD)0xC000008FL)
#define STATUS_FLOAT_INVALID_OPERATION ((DWORD)0xC0000090L)
#define STATUS_FLOAT_OVERFLOW ((DWORD)0xC0000091L)
#define STATUS_FLOAT_STACK_CHECK ((DWORD)0xC0000092L)
#define STATUS_FLOAT_UNDERFLOW ((DWORD)0xC0000093L)
#define STATUS_INTEGER_DIVIDE_BY_ZERO ((DWORD)0xC0000094L)
#define STATUS_INTEGER_OVERFLOW ((DWORD)0xC0000095L)
#define STATUS_PRIVILEGED_INSTRUCTION ((DWORD)0xC0000096L)
#define STATUS_DATA_OVERRUN ((DWORD)0xC000003CL)
#define STATUS_INVALID_IMAGE_FORMAT ((DWORD)0xC000007BL)
#define STATUS_INSUFFICIENT_RESOURCES ((DWORD)0xC000009AL)
#define STATUS_FILE_IS_A_DIRECTORY ((DWORD)0xC00000BAL)
#define STATUS_INVALID_PARAMETER_1 ((DWORD)0xC00000EFL)
#define STATUS_INVALID_PARAMETER_2 ((DWORD)0xC00000F0L)
#define STATUS_INVALID_PARAMETER_3 ((DWORD)0xC00000F1L)
#define STATUS_INVALID_PARAMETER_4 ((DWORD)0xC00000F2L)
#define STATUS_INVALID_PARAMETER_5 ((DWORD)0xC00000F3L)
#define STATUS_INVALID_PARAMETER_6 ((DWORD)0xC00000F4L)
#define STATUS_INVALID_PARAMETER_7 ((DWORD)0xC00000F5L)
#define STATUS_INVALID_PARAMETER_8 ((DWORD)0xC00000F6L)
#define STATUS_INVALID_PARAMETER_9 ((DWORD)0xC00000F7L)
#define STATUS_INVALID_PARAMETER_10 ((DWORD)0xC00000F8L)
#define STATUS_INVALID_PARAMETER_11 ((DWORD)0xC00000F9L)
#define STATUS_INVALID_PARAMETER_12 ((DWORD)0xC00000FAL)
#define STATUS_STACK_OVERFLOW ((DWORD)0xC00000FDL)
#define STATUS_CONTROL_C_EXIT ((DWORD)0xC000013AL)
#define STATUS_TOO_MANY_SECRETS ((DWORD)0xC0000156L)
#define STATUS_HANDLE_NOT_CLOSABLE ((DWORD)0xC0000235L)
#define STATUS_IMAGE_GAME_REGION_VIOLATION ((DWORD)0xC0050001L)
#define STATUS_IMAGE_MEDIA_TYPE_VIOLATION ((DWORD)0xC0050002L)
#define STATUS_SUCCESS ((NTSTATUS)0x00000000L)
#define STATUS_WAIT_0 ((NTSTATUS)0x00000000L)
#define STATUS_ABANDONED_WAIT_0 ((NTSTATUS)0x00000080L)
#define STATUS_USER_APC ((NTSTATUS)0x000000C0L)
#define STATUS_ALERTED ((NTSTATUS)0x00000101L)
#define STATUS_TIMEOUT ((NTSTATUS)0x00000102L)
#define STATUS_PENDING ((NTSTATUS)0x00000103L)
#define STATUS_OBJECT_NAME_EXISTS ((NTSTATUS)0x40000000L)
#define STATUS_NO_YIELD_PERFORMED ((NTSTATUS)0x40000024L)
#define STATUS_SEGMENT_NOTIFICATION ((NTSTATUS)0x40000005L)
#define STATUS_GUARD_PAGE_VIOLATION ((NTSTATUS)0x80000001L)
#define STATUS_DATATYPE_MISALIGNMENT ((NTSTATUS)0x80000002L)
#define STATUS_BREAKPOINT ((NTSTATUS)0x80000003L)
#define STATUS_SINGLE_STEP ((NTSTATUS)0x80000004L)
#define STATUS_BUFFER_OVERFLOW ((NTSTATUS)0x80000005L)
#define STATUS_NO_MORE_FILES ((NTSTATUS)0x80000006L)
#define STATUS_NO_MORE_ENTRIES ((NTSTATUS)0x8000001AL)
#define STATUS_UNSUCCESSFUL ((NTSTATUS)0xC0000001L)
#define STATUS_ACCESS_VIOLATION ((NTSTATUS)0xC0000005L)
#define STATUS_IN_PAGE_ERROR ((NTSTATUS)0xC0000006L)
#define STATUS_INVALID_HANDLE ((NTSTATUS)0xC0000008L)
#define STATUS_INVALID_PARAMETER ((NTSTATUS)0xC000000DL)
#define STATUS_END_OF_FILE ((NTSTATUS)0xC0000011L)
#define STATUS_NO_MEMORY ((NTSTATUS)0xC0000017L)
#define STATUS_ILLEGAL_INSTRUCTION ((NTSTATUS)0xC000001DL)
#define STATUS_ALREADY_COMMITTED ((NTSTATUS)0xC0000021L)
#define STATUS_ACCESS_DENIED ((NTSTATUS)0xC0000022L)
#define STATUS_BUFFER_TOO_SMALL ((NTSTATUS)0xC0000023L)
#define STATUS_OBJECT_TYPE_MISMATCH ((NTSTATUS)0xC0000024L)
#define STATUS_NONCONTINUABLE_EXCEPTION ((NTSTATUS)0xC0000025L)
#define STATUS_INVALID_DISPOSITION ((NTSTATUS)0xC0000026L)
#define STATUS_OBJECT_NAME_INVALID ((NTSTATUS)0xC0000033L)
#define STATUS_OBJECT_NAME_NOT_FOUND ((NTSTATUS)0xC0000034L)
#define STATUS_OBJECT_NAME_COLLISION ((NTSTATUS)0xC0000035L)
#define STATUS_OBJECT_PATH_NOT_FOUND ((NTSTATUS)0xC000003AL)
#define STATUS_MUTANT_NOT_OWNED ((NTSTATUS)0xC0000046L)
#define STATUS_SEMAPHORE_LIMIT_EXCEEDED ((NTSTATUS)0xC0000047L)
#define STATUS_ARRAY_BOUNDS_EXCEEDED ((NTSTATUS)0xC000008CL)
#define STATUS_FLOAT_DENORMAL_OPERAND ((NTSTATUS)0xC000008DL)
#define STATUS_FLOAT_DIVIDE_BY_ZERO ((NTSTATUS)0xC000008EL)
#define STATUS_FLOAT_INEXACT_RESULT ((NTSTATUS)0xC000008FL)
#define STATUS_FLOAT_INVALID_OPERATION ((NTSTATUS)0xC0000090L)
#define STATUS_FLOAT_OVERFLOW ((NTSTATUS)0xC0000091L)
#define STATUS_FLOAT_STACK_CHECK ((NTSTATUS)0xC0000092L)
#define STATUS_FLOAT_UNDERFLOW ((NTSTATUS)0xC0000093L)
#define STATUS_INTEGER_DIVIDE_BY_ZERO ((NTSTATUS)0xC0000094L)
#define STATUS_INTEGER_OVERFLOW ((NTSTATUS)0xC0000095L)
#define STATUS_PRIVILEGED_INSTRUCTION ((NTSTATUS)0xC0000096L)
#define STATUS_DATA_OVERRUN ((NTSTATUS)0xC000003CL)
#define STATUS_INVALID_IMAGE_FORMAT ((NTSTATUS)0xC000007BL)
#define STATUS_INSUFFICIENT_RESOURCES ((NTSTATUS)0xC000009AL)
#define STATUS_FILE_IS_A_DIRECTORY ((NTSTATUS)0xC00000BAL)
#define STATUS_INVALID_PARAMETER_1 ((NTSTATUS)0xC00000EFL)
#define STATUS_INVALID_PARAMETER_2 ((NTSTATUS)0xC00000F0L)
#define STATUS_INVALID_PARAMETER_3 ((NTSTATUS)0xC00000F1L)
#define STATUS_INVALID_PARAMETER_4 ((NTSTATUS)0xC00000F2L)
#define STATUS_INVALID_PARAMETER_5 ((NTSTATUS)0xC00000F3L)
#define STATUS_INVALID_PARAMETER_6 ((NTSTATUS)0xC00000F4L)
#define STATUS_INVALID_PARAMETER_7 ((NTSTATUS)0xC00000F5L)
#define STATUS_INVALID_PARAMETER_8 ((NTSTATUS)0xC00000F6L)
#define STATUS_INVALID_PARAMETER_9 ((NTSTATUS)0xC00000F7L)
#define STATUS_INVALID_PARAMETER_10 ((NTSTATUS)0xC00000F8L)
#define STATUS_INVALID_PARAMETER_11 ((NTSTATUS)0xC00000F9L)
#define STATUS_INVALID_PARAMETER_12 ((NTSTATUS)0xC00000FAL)
#define STATUS_STACK_OVERFLOW ((NTSTATUS)0xC00000FDL)
#define STATUS_CONTROL_C_EXIT ((NTSTATUS)0xC000013AL)
#define STATUS_TOO_MANY_SECRETS ((NTSTATUS)0xC0000156L)
#define STATUS_HANDLE_NOT_CLOSABLE ((NTSTATUS)0xC0000235L)
#define STATUS_IMAGE_GAME_REGION_VIOLATION ((NTSTATUS)0xC0050001L)
#define STATUS_IMAGE_MEDIA_TYPE_VIOLATION ((NTSTATUS)0xC0050002L)

#endif

Loading