This repository was archived by the owner on Apr 3, 2023. It is now read-only.
Adding option to not mount /proc at boot and adding Arch Linux.#2
Open
AroPix wants to merge 2 commits intoXRadius:masterfrom
Open
Adding option to not mount /proc at boot and adding Arch Linux.#2AroPix wants to merge 2 commits intoXRadius:masterfrom
AroPix wants to merge 2 commits intoXRadius:masterfrom
Conversation
- I significantly removed the lines where the root user is needed, as this is very unsafe. - I added the commands for Arch based linux distros to the commands - I added a command that mounts `/proc` instead of auto-mounting it via fstab, this ensures (as example for dailydriver users like me), that everything works fine, because as example mounting a drive through Dolphin doesn't work when processes are hidden.
- Added a temporary command for ptrace, so it isn't persistent on reboot, as things break (as example League Of Legends from Lutris)
Owner
|
Thank you for this PR! There are, unfortunately, a few things that I disagree with in this PR:
If you're willing to make these modifications, I'll happily merge your work to improve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/procinstead of auto-mounting it via fstab, this ensures (as example for dailydriver users like me), that everything works fine, because as example mounting a drive through Dolphin doesn't work when processes are hidden.