Skip to content

remove dead functions due to integration#6683

Open
yinyiqian1 wants to merge 1 commit intoXRPLF:ripple/confidential-transferfrom
yinyiqian1:remove-func
Open

remove dead functions due to integration#6683
yinyiqian1 wants to merge 1 commit intoXRPLF:ripple/confidential-transferfrom
yinyiqian1:remove-func

Conversation

@yinyiqian1
Copy link
Copy Markdown
Collaborator

High Level Overview of Change

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@yinyiqian1 yinyiqian1 marked this pull request as ready for review March 27, 2026 21:15
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.1%. Comparing base (2c94e21) to head (ece6ed1).
⚠️ Report is 11 commits behind head on ripple/confidential-transfer.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           ripple/confidential-transfer   #6683     +/-   ##
==============================================================
- Coverage                          80.2%   80.1%   -0.1%     
==============================================================
  Files                               874     874             
  Lines                             69184   68747    -437     
  Branches                           7562    7548     -14     
==============================================================
- Hits                              55464   55041    -423     
+ Misses                            13720   13706     -14     
Files with missing lines Coverage Δ
include/xrpl/protocol/ConfidentialTransfer.h 87.5% <ø> (-12.5%) ⬇️
src/libxrpl/protocol/ConfidentialTransfer.cpp 93.8% <ø> (+1.7%) ⬆️

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yinyiqian1 yinyiqian1 requested a review from shawnxie999 March 27, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant