chore: Remove unnecessary clang-format off/on directives#6682
Open
chore: Remove unnecessary clang-format off/on directives#6682
Conversation
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
bthomee
added
the
Trivial
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6682 +/- ##
=========================================
- Coverage 81.5% 81.4% -0.0%
=========================================
Files 999 999
Lines 74456 74456
Branches 7559 7559
=========================================
- Hits 60651 60643 -8
- Misses 13805 13813 +8
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change removes unnecessary
// clang-format offand// clang-format ondirectives that surround blocks of code.Context of Change
The clang-format off/on directives can help with formatting code in specific ways, e.g. to force vertical alignment of values across multiple lines. Certain comments implicitly suggested that the last time one looked at these statements was when Clang 10 still existed. It was therefore time to take another look.
For this PR: