refactor: Rename non-functional uses of ripple(d) to xrpl(d)#6676
refactor: Rename non-functional uses of ripple(d) to xrpl(d)#6676
ripple(d) to xrpl(d)#6676Conversation
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
There was a problem hiding this comment.
Went through the changes
Two TSan suppression patterns (xrpl::ServerHandler, xrpl::Workers::Worker) will silently break if the actual namespace in the compiled binary is still ripple:: — needs confirmation before merge. Also, the pinned historical URL in README.md was incorrectly rewritten to src/rippled/ when that path didn't exist at that commit. See inline comments.
Review by ReviewBot 🤖
Review by Claude Opus 4.6 · Prompt: V12
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6676 +/- ##
=========================================
- Coverage 81.5% 81.4% -0.0%
=========================================
Files 999 999
Lines 74456 74457 +1
Branches 7559 7559
=========================================
- Hits 60651 60644 -7
- Misses 13805 13813 +8
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Several correctness bugs flagged inline: sed alternation patterns are no-ops without -E (lines 41-47 of docs.sh), a typo makes one pattern unmatchable, the namespace.sh replacement corrupts config section strings, and two documentation paths/URLs are broken (/etc/opt/ for a binary, dead XRPLF/xrpld links). Also worth confirming the renamed package repo URLs are live before merging.
Review by Claude Opus 4.6 · Prompt: V12
There was a problem hiding this comment.
Several correctness issues flagged inline: two regex bugs in docs.sh (unintended character-class range on line 35, word-boundary missing on line 48), an asymmetric colon in namespace.sh line 44, a cert/script O= mismatch in TrustedPublisherServer.h, a grammar nit in xrpld-example.cfg, and unverified live URLs in install.md.
Review by Claude Opus 4.6 · Prompt: V12
There was a problem hiding this comment.
Went through the changes
Two over-broad TSan suppressions lost their namespace qualifier (should be xrpl::) — see inline. A colon-count mismatch in the rename script will silently misfire. Install docs reference renamed infra URLs that will break users if not yet live.
Review by ReviewBot 🤖
Review by Claude Opus 4.6 · Prompt: V12
There was a problem hiding this comment.
Critical sed bug in namespace.sh corrupts URI string literals (line 44). Functional install URLs/package names changed in docs without confirmed infra readiness. TSAN suppressions lost their namespace qualifiers. See inline comments.
Review by Claude Opus 4.6 · Prompt: V12
There was a problem hiding this comment.
Several real bugs found — see inline comments. The namespace.sh sed command introduces an extra colon into string literals (high severity). TSAN suppressions dropped namespace qualifiers instead of updating them, making them overly broad. Package repo URLs need infrastructure verification before merging.
Review by Claude Opus 4.6 · Prompt: V12
| as implemented in [xrpld](https://github.com/XRPLF/rippled), but | ||
| focuses on its utility as a generic consensus algorithm independent of the | ||
| detailed mechanics of the Ripple Consensus Ledger. Most notably, the algorithm | ||
| detailed mechanics of the XRPL consensus Ledger. Most notably, the algorithm |
There was a problem hiding this comment.
Inconsistent capitalization in proper noun — consensus should be capitalized to match "XRPL Consensus Ledger" (same issue on line 59):
| detailed mechanics of the XRPL consensus Ledger. Most notably, the algorithm | |
| detailed mechanics of the XRPL Consensus Ledger. Most notably, the algorithm |
2 participants
High Level Overview of Change
This change modifies non-functional uses of
ripple(d)toxrpl(d), such as in documentation, comments, and internal function names.Context of Change
Per XLS-0095, we are taking steps to rename ripple(d) to xrpl(d).
This change updates the references in files that have no impact on functionality of the binary. Note that the current documentation is known to be out of date. This PR does not address this issue. A full rewrite of the documentation and ensuring it is correct is planned for later this year. The
docs/README.mdfile was deleted, however, as it was no longer relevant.Note that a small tweak was made to the config and namespace scripts, as some of the changes found during development of this PR better belong in those files.
A few functions were renamed:
rippleLockEscrowMPTandrippleUnlockEscrowMPTtolockEscrowMPTandunlockEscrowMPT, resp.rippleCredit,rippleCreditIOU, andrippleCreditMPTtodirectSendNoFee,directSendNoFeeIOU, anddirectSendNoFeeMPT, resp.rippleSendIOU,rippleSendMultiIOU,rippleSendMPT, andrippleSendMultiMPTtodirectSendNoLimitIOU,directSendNoLimitMultiIOU,directSendNoLimitMPT, anddirectSendNoLimitMultiMPT, resp.isRippledVersiontoisXrpldVersion.parseRippleLibSeedtoparseXrplLibSeed.testRippleLibEd25519totestXrplLibEd25519.Changes that were not made: