Skip to content

add tests: encrypt under wrong public key#6650

Merged
shawnxie999 merged 7 commits intoXRPLF:ripple/confidential-transferfrom
PeterChen13579:encrypt_wrong_public_key_test
Mar 30, 2026
Merged

add tests: encrypt under wrong public key#6650
shawnxie999 merged 7 commits intoXRPLF:ripple/confidential-transferfrom
PeterChen13579:encrypt_wrong_public_key_test

Conversation

@PeterChen13579
Copy link
Copy Markdown
Collaborator

High Level Overview of Change

Context of Change

Add tests and small checks under confidential MPT

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@PeterChen13579 PeterChen13579 marked this pull request as draft March 25, 2026 16:50
@PeterChen13579 PeterChen13579 marked this pull request as ready for review March 26, 2026 14:35
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.0%. Comparing base (2c94e21) to head (2542a77).
⚠️ Report is 12 commits behind head on ripple/confidential-transfer.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           ripple/confidential-transfer   #6650     +/-   ##
==============================================================
- Coverage                          80.2%   80.0%   -0.2%     
==============================================================
  Files                               874     874             
  Lines                             69184   68779    -405     
  Branches                           7562    7568      +6     
==============================================================
- Hits                              55464   55034    -430     
- Misses                            13720   13745     +25     
Files with missing lines Coverage Δ
...l/tx/transactors/token/ConfidentialMPTClawback.cpp 97.3% <100.0%> (+<0.1%) ⬆️

... and 11 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/libxrpl/tx/transactors/token/ConfidentialMPTClawback.cpp
Comment thread src/test/app/ConfidentialTransfer_test.cpp
Comment thread src/test/app/ConfidentialTransfer_test.cpp Outdated
Comment thread src/test/jtx/impl/mpt.cpp Outdated
@shawnxie999 shawnxie999 merged commit 13b3a24 into XRPLF:ripple/confidential-transfer Mar 30, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants