docs: Add explanatory comment to checkFee#6631
Open
yinyiqian1 wants to merge 2 commits intoXRPLF:developfrom
Open
docs: Add explanatory comment to checkFee#6631yinyiqian1 wants to merge 2 commits intoXRPLF:developfrom
yinyiqian1 wants to merge 2 commits intoXRPLF:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6631 +/- ##
=========================================
- Coverage 81.4% 81.4% -0.0%
=========================================
Files 997 997
Lines 74415 74410 -5
Branches 7561 7562 +1
=========================================
- Hits 60611 60595 -16
- Misses 13804 13815 +11
🚀 New features to boost your workflow:
|
shawnxie999
approved these changes
Mar 24, 2026
mvadari
approved these changes
Mar 24, 2026
Collaborator
mvadari
left a comment
There was a problem hiding this comment.
The PR title should be fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explanatory comment to checkFee to avoid false alarm detection.
High Level Overview of Change
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)