Skip to content

docs: Add explanatory comment to checkFee#6631

Open
yinyiqian1 wants to merge 2 commits intoXRPLF:developfrom
yinyiqian1:fix-payer
Open

docs: Add explanatory comment to checkFee#6631
yinyiqian1 wants to merge 2 commits intoXRPLF:developfrom
yinyiqian1:fix-payer

Conversation

@yinyiqian1
Copy link
Copy Markdown
Collaborator

@yinyiqian1 yinyiqian1 commented Mar 24, 2026

Add explanatory comment to checkFee to avoid false alarm detection.

High Level Overview of Change

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.4%. Comparing base (8b986e4) to head (a243a45).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6631     +/-   ##
=========================================
- Coverage     81.4%   81.4%   -0.0%     
=========================================
  Files          997     997             
  Lines        74415   74410      -5     
  Branches      7561    7562      +1     
=========================================
- Hits         60611   60595     -16     
- Misses       13804   13815     +11     
Files with missing lines Coverage Δ
src/libxrpl/tx/Transactor.cpp 93.2% <ø> (ø)

... and 32 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yinyiqian1 yinyiqian1 added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 24, 2026
Copy link
Copy Markdown
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title should be fixed

@yinyiqian1 yinyiqian1 changed the title docs: Add explanatory comment to delegate checkFee docs: Add explanatory comment to checkFee Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants