Open
Conversation
mvadari
requested changes
Mar 24, 2026
Collaborator
mvadari
left a comment
There was a problem hiding this comment.
This needs an amendment to gate the change, as it would break consensus as-is. It also needs proper tests to a) ensure that 500 trustlines are deleted with this and b) that behavior remains the same before the amendment is enabled.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6627 +/- ##
=========================================
- Coverage 81.5% 81.4% -0.0%
=========================================
Files 997 997
Lines 74415 74414 -1
Branches 7579 7562 -17
=========================================
- Hits 60615 60597 -18
- Misses 13800 13817 +17
🚀 New features to boost your workflow:
|
Author
thanks for feedbacks, let me to check to solve it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Replace the all-or-nothing size guard in
removeDeletedTrustLineswith aniterate-up-to-limit loop, so each
AMMDeletetransaction cleans up as manyAMM trust lines as the per-transaction cap allows instead of abandoning
cleanup entirely when that cap is exceeded.
Fixes #6614
Context of Change
removeDeletedTrustLinesis called at the end ofTransactor::operator()when a transaction returns
tecINCOMPLETE. Its job is to finalize deletionof AMM trust lines that were marked for removal during transaction processing.
The previous implementation contained this guard: