feat: Implement VaultList for Lending Protocol#2972
Conversation
| // Parse the MPT Issuance ID from input | ||
| auto const mptID = ripple::uint192{input.tokenID.c_str()}; |
There was a problem hiding this comment.
Will check if this is correct way to name/get the id
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2972 +/- ##
===========================================
+ Coverage 81.96% 82.04% +0.07%
===========================================
Files 396 398 +2
Lines 16026 16133 +107
Branches 8377 8442 +65
===========================================
+ Hits 13136 13236 +100
+ Misses 1679 1678 -1
- Partials 1211 1219 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
godexsoft
left a comment
godexsoft
left a comment
There was a problem hiding this comment.
Overall this is looking good. Leaving a few questions and mostly nits.
| namespace rpc { | ||
|
|
||
| /** | ||
| * @brief The vault_list command retrieves all Vaults created by a particular Token. |
There was a problem hiding this comment.
Why is this RPC only for MPTs? WHy not IOUs and XRP?
Edit: a Token cannot create a Vault. I assume you meant to say that vault_list retrieves all vaults for a given token?
There was a problem hiding this comment.
I fixed the comment, thanks. I'll take a look how to implement it for all token types in a similar fashion
There was a problem hiding this comment.
I was looking at https://github.com/XRPLF/clio/blob/develop/src/rpc/handlers/VaultInfo.cpp#L138, which seems to deal with MPTs only
mathbunnyru
force-pushed
the
lending_rpc
branch
from
cd2a0be to
b7c9d9c
Compare
3 participants
No description provided.