Skip to content

Potential fixes for 2 code quality findings #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PythonSmall-Q merged 4 commits into from
Mar 20, 2026
Merged

Potential fixes for 2 code quality findings #61

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18391e7
Apply suggested fix to Source/index.ts from Copilot Autofix
langningchen Mar 19, 2026
31ed585
Apply suggested fix to Source/index.ts from Copilot Autofix
langningchen Mar 19, 2026
70faa23
Update Source/index.ts
langningchen Mar 20, 2026
9e0a888
Update Source/index.ts
langningchen Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions Source/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import {Process} from "./Process";
import {Database} from "./Database";
import {NotificationManager} from "./NotificationManager";
import {D1Database, KVNamespace, AnalyticsEngineDataset, DurableObjectNamespace} from "@cloudflare/workers-types";
import type {D1Database, KVNamespace, AnalyticsEngineDataset, DurableObjectNamespace, Ai} from "@cloudflare/workers-types";

interface Environment {
API_TOKEN: string;
Expand All @@ -29,15 +29,22 @@ interface Environment {
CaptchaSecretKey: string;
DB: D1Database;
logdb: AnalyticsEngineDataset;
AI: any;
AI: Ai;
NOTIFICATIONS: DurableObjectNamespace;
NOTIFICATION_PUSH_TOKEN: string;
Comment thread
langningchen marked this conversation as resolved.
}

const ParseUsernameFromProfile = (profilePage: string): string => {
let username = profilePage.substring(profilePage.indexOf("user_id=") + 8);
username = username.substring(0, username.indexOf("'"));
return username;
const userIdIndex = profilePage.indexOf("user_id=");
if (userIdIndex === -1) {
return "";
}
const usernameStart = userIdIndex + "user_id=".length;
Comment thread
langningchen marked this conversation as resolved.
const closingQuoteIndex = profilePage.indexOf("'", usernameStart);
if (closingQuoteIndex === -1) {
return "";
}
return profilePage.substring(usernameStart, closingQuoteIndex);
};

const isValidSessionID = (sessionID: string): boolean => {
Expand Down
Loading