Skip to content

Add ELXMOJ client section to index.html#954

Open
PythonSmall-Q wants to merge 2 commits intodevfrom
elxmoJ-patch
Open

Add ELXMOJ client section to index.html#954
PythonSmall-Q wants to merge 2 commits intodevfrom
elxmoJ-patch

Conversation

@PythonSmall-Q
Copy link
Member

@PythonSmall-Q PythonSmall-Q commented Mar 22, 2026

Added a new section for ELXMOJ client with links and description.

What does this PR aim to accomplish?:

How does this PR accomplish the above?:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributor's guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented on my proposed changes within the code.
  3. I have tested my changes.
  4. I am willing to help maintain this change if there are issues with it later.
  5. It is compatible with the GNU General Public License v3.0
  6. I have squashed any insignificant commits. (git rebase)
  7. I have checked that another pull request for this purpose does not exist.
  8. I have considered and confirmed that this submission will be valuable to others.
  9. I accept that this submission may not be used, and the pull request can be closed at the will of the maintainer.
  10. I give this submission freely and claim no ownership to its content.
  11. I have verified that my changes work correctly in both the new UI and the old/classic UI.

  • I have read the above and my PR is ready for review. Check this box to confirm

Summary by Sourcery

Add an ELXMOJ client entry point to the main page navigation and content.

New Features:

  • Introduce a new ELXMOJ client navigation link in the main navbar.
  • Add a dedicated ELXMOJ client section describing the web client and linking to its URL.

Added a new section for ELXMOJ client with links and description.

Signed-off-by: Shan Wenxiao <seanoj_noreply@yeah.net>
Copilot AI review requested due to automatic review settings March 22, 2026 08:52
@PythonSmall-Q PythonSmall-Q requested review from boomzero and removed request for Copilot March 22, 2026 08:52
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 22, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds an ELXMOJ client navigation item and a new content section in index.html that describes and links to the ELXMOJ web client, emphasizing it as a browser-extension-free way to use XMOJ-Script features.

Flow diagram for new ELXMOJ navigation and content links

flowchart TD
  Index[index_html]
  NavMenu[Navigation_menu]
  ELXNavItem[ELXMOJ_nav_item]
  ELXSection[ELXMOJ_content_section]
  ELXSite[ELXMOJ_web_client]

  Index --> NavMenu
  NavMenu --> ELXNavItem
  Index --> ELXSection

  ELXNavItem -->|href_https_elxmoj_xmoj_bbs_me| ELXSite
  ELXSection -->|primary_anchor_link| ELXSite
  ELXSection -->|here_anchor_link| ELXSite
Loading

File-Level Changes

Change Details Files
Add ELXMOJ client entry to the main navigation bar.
  • Insert a new nav-item with link text 'ELxmoj 客户端' in the existing navbar list.
  • Configure the link to open https://elxmoj.xmoj-bbs.me in a new tab with appropriate security attributes (noopener noreferrer).
index.html
Introduce a dedicated ELXMOJ client section in the main content area.
  • Add a new container section with id 'ELXMOJ' and heading 'ELXMOJ 客户端' before the Feedback section.
  • Describe ELXMOJ as the XMOJ-Script web client that provides enhanced functionality without requiring a browser extension.
  • Include inline links to https://elxmoj.xmoj-bbs.me using target=_blank and rel='noopener noreferrer' for secure external navigation.
index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 22, 2026

Deploying xmoj-script-dev-channel with  Cloudflare Pages  Cloudflare Pages

Latest commit: cc75291
Status: ✅  Deploy successful!
Preview URL: https://23d5360c.xmoj-script-dev-channel.pages.dev
Branch Preview URL: https://elxmoj-patch.xmoj-script-dev-channel.pages.dev

View logs

@hendragon-bot hendragon-bot bot added the website This issue or pull request is related to website related files label Mar 22, 2026
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The navigation item label uses ELxmoj while the section and links use ELXMOJ; align the naming consistently across the nav and content to avoid confusion.
  • Consider making the new nav item link to the #ELXMOJ section instead of (or in addition to) the external URL so users can quickly discover the description and context on the same page.
  • For accessibility, avoid generic link text like “这里” and make the second link text more descriptive (e.g., “访问 ELXMOJ 客户端”) so screen readers convey clearer context.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The navigation item label uses `ELxmoj` while the section and links use `ELXMOJ`; align the naming consistently across the nav and content to avoid confusion.
- Consider making the new nav item link to the `#ELXMOJ` section instead of (or in addition to) the external URL so users can quickly discover the description and context on the same page.
- For accessibility, avoid generic link text like “这里” and make the second link text more descriptive (e.g., “访问 ELXMOJ 客户端”) so screen readers convey clearer context.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Signed-off-by: Shan Wenxiao <seanoj_noreply@yeah.net>
Copilot AI review requested due to automatic review settings March 22, 2026 08:55
@PythonSmall-Q PythonSmall-Q review requested due to automatic review settings March 22, 2026 08:56
@PythonSmall-Q PythonSmall-Q enabled auto-merge March 22, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S website This issue or pull request is related to website related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant