Skip to content

Gate WebSocket toast notifications by per-feature popup settings#919

Merged
boomzero merged 9 commits intodevfrom
fix/websocket-toast-gating
Feb 23, 2026
Merged

Gate WebSocket toast notifications by per-feature popup settings#919
boomzero merged 9 commits intodevfrom
fix/websocket-toast-gating

Conversation

@boomzero
Copy link
Member

@boomzero boomzero commented Feb 23, 2026

What does this PR aim to accomplish?:

The WebSocket notification handler (HandleNotificationMessage) dispatches bbs_mention and mail_mention toasts unconditionally, bypassing the user's BBSPopup / MessagePopup toggle settings. The polling fallback (PollNotifications) already gates each toast type with UtilityEnabled(), so behavior differs depending on connection state — users who disabled a notification type still receive those toasts over WebSocket.

How does this PR accomplish the above?:

Wraps the CreateAndShowBBSMentionToast and CreateAndShowMailMentionToast calls in HandleNotificationMessage with UtilityEnabled("BBSPopup") and UtilityEnabled("MessagePopup") checks respectively, matching the pattern used by PollNotifications.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributor's guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented on my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the GNU General Public License v3.0
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request can be closed at the will of the maintainer.
  9. I give this submission freely and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Summary by cubic

Gate WebSocket toast notifications by the user's popup settings so disabled types no longer show. bbs_mention now respects BBSPopup and mail_mention respects MessagePopup; version bumped to 3.2.2 (prerelease) and Update.json notes/time updated.

Written for commit c6fd5b9. Summary will update on new commits.

The WebSocket handler called CreateAndShowBBSMentionToast and
CreateAndShowMailMentionToast unconditionally, ignoring the user's
BBSPopup/MessagePopup toggle. This made behavior differ from the
polling fallback, which already checks UtilityEnabled() per type.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@hendragon-bot hendragon-bot bot added the user-script This issue or pull request is related to the main user script label Feb 23, 2026
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@github-actions github-actions bot force-pushed the fix/websocket-toast-gating branch from c6fd5b9 to f63b4d3 Compare February 23, 2026 12:16
@boomzero boomzero merged commit 5638671 into dev Feb 23, 2026
@boomzero boomzero deleted the fix/websocket-toast-gating branch February 23, 2026 12:16
@boomzero boomzero mentioned this pull request Feb 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S user-script This issue or pull request is related to the main user script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant