Merged
Conversation
Sanitize user-controlled data with escapeHTML() before innerHTML insertion: - Post titles in thread list - Board name in thread view - EditPerson username in reply edit info - UserID and UserNick on profile page - Update description in changelog Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:3">
P2: Avoid manual version bumps; version numbers are managed by the automated UpdateVersion workflow, so this change will be overwritten and can cause version sync issues.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| { | ||
| "name": "xmoj-script", | ||
| "version": "3.1.1", | ||
| "version": "3.1.2", |
There was a problem hiding this comment.
P2: Avoid manual version bumps; version numbers are managed by the automated UpdateVersion workflow, so this change will be overwritten and can cause version sync issues.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 3:
<comment>Avoid manual version bumps; version numbers are managed by the automated UpdateVersion workflow, so this change will be overwritten and can cause version sync issues.</comment>
<file context>
@@ -1,6 +1,6 @@
{
"name": "xmoj-script",
- "version": "3.1.1",
+ "version": "3.1.2",
"description": "an improvement script for xmoj.tech",
"main": "AddonScript.js",
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Fix remaining stored XSS vulnerabilities (follow-up to #910) where unsanitized user-controlled data is inserted via
innerHTML, allowing arbitrary script execution.How does this PR accomplish the above?:
Wrap user-controlled data with
escapeHTML()before inserting intoinnerHTML:Posts[i].Title)ResponseData.Data.BoardName)Replies[i].EditPerson)Data.UpdateContents[j].Description)By submitting this pull request, I confirm the following:
git rebase)Summary by cubic
Fixes remaining stored XSS by escaping user-controlled values before inserting via innerHTML. Also bumps version to 3.1.2 and adds release notes.
Written for commit e51cb29. Summary will update on new commits.