Skip to content

feat: use credential management api#834

Merged
boomzero merged 3 commits intodevfrom
codex/upgrade-password-storage-to-credential-management-api-0e58t0
Aug 19, 2025
Merged

feat: use credential management api#834
boomzero merged 3 commits intodevfrom
codex/upgrade-password-storage-to-credential-management-api-0e58t0

Conversation

@boomzero
Copy link
Member

Summary

  • add helper functions to store, load, and clear credentials
  • use Credential Management API to save, retrieve, and clear login data instead of plaintext localStorage
  • wrap credential retrieval and storage in async contexts to avoid syntax errors

Testing

  • npm test (fails: Error: no test specified)

https://chatgpt.com/codex/tasks/task_e_68a417a979e08332b8d1408faef6f3ff

@hendragon-bot hendragon-bot bot added the user-script This issue or pull request is related to the main user script label Aug 19, 2025
@boomzero boomzero marked this pull request as draft August 19, 2025 07:38
@boomzero boomzero marked this pull request as ready for review August 19, 2025 07:53
@boomzero
Copy link
Member Author

Well, it works

@boomzero
Copy link
Member Author

@langningchen @PythonSmall-Q Well this works, so merge?

@boomzero
Copy link
Member Author

boomzero commented Aug 19, 2025

The behavior is a bit different though

@boomzero
Copy link
Member Author

boomzero commented Aug 19, 2025

@langningchen @PythonSmall-Q Well this works, so merge?

You should test it to see if you like the new behavior

@boomzero
Copy link
Member Author

boomzero commented Aug 19, 2025

btw completely AI generated

@boomzero boomzero requested a review from langningchen August 19, 2025 08:36
Copy link
Member

@langningchen langningchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I haven't tested it, I think it would be great if it could work!

@boomzero
Copy link
Member Author

boomzero commented Aug 19, 2025

Well as I said, there is a change in behavior, so it probably should be tested

@boomzero
Copy link
Member Author

Though perhaps I should merge it so that more people can test it

@boomzero boomzero merged commit ca06a1e into dev Aug 19, 2025
3 checks passed
@boomzero boomzero deleted the codex/upgrade-password-storage-to-credential-management-api-0e58t0 branch August 19, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex size/M user-script This issue or pull request is related to the main user script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants