fix: reinfo.php shows no test results even if test results are available#815
Closed
fix: reinfo.php shows no test results even if test results are available#815
Conversation
hendragon-bot
bot
added
the
user-script
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures test point information is displayed correctly on /reinfo.php and replaces a raw error block with a user-friendly message on /downloads.php.
- Refactored the existence check for test results in
reinfo.phpto only iterate when results exist. - Added a replacement for the default error
<pre>indownloads.phpto show “没有测试点信息.”
| if (document.querySelector("#results > div") == undefined) { | ||
| document.querySelector("#results").parentElement.innerHTML = "没有测试点信息"; | ||
| } else { | ||
| if (document.querySelector("#results > div") != undefined) { |
There was a problem hiding this comment.
The fallback message for when no test results are available was removed. Reintroduce an else branch to display “没有测试点信息” when document.querySelector("#results > div") returns undefined.
Comment on lines
+3358
to
3360
| if (document.querySelector("#results > div") != undefined) { | ||
| for (let i = 0; i < document.querySelector("#results > div").children.length; i++) { | ||
| let CurrentElement = document.querySelector("#results > div").children[i].children[0].children[0].children[0]; |
There was a problem hiding this comment.
Cache the result of document.querySelector("#results > div") into a variable before the loop to avoid repeated DOM queries and improve readability.
Suggested change
| if (document.querySelector("#results > div") != undefined) { | |
| for (let i = 0; i < document.querySelector("#results > div").children.length; i++) { | |
| let CurrentElement = document.querySelector("#results > div").children[i].children[0].children[0].children[0]; | |
| const resultsDiv = document.querySelector("#results > div"); | |
| if (resultsDiv != undefined) { | |
| for (let i = 0; i < resultsDiv.children.length; i++) { | |
| let CurrentElement = resultsDiv.children[i].children[0].children[0].children[0]; |
| }); | ||
| } | ||
| } | ||
| document.body.innerHTML = String(document.body.innerHTML).replaceAll("<pre id=\"errtxt\" class=\"alert alert-error\">sorry , not available (,,,1)</pre>", "没有测试点信息"); |
There was a problem hiding this comment.
Replacing the entire body.innerHTML can break event listeners and is fragile. Instead, target the specific <pre id="errtxt"> element (e.g., via getElementById) and update its textContent.
Suggested change
| document.body.innerHTML = String(document.body.innerHTML).replaceAll("<pre id=\"errtxt\" class=\"alert alert-error\">sorry , not available (,,,1)</pre>", "没有测试点信息"); | |
| let errorTextElement = document.getElementById("errtxt"); | |
| if (errorTextElement) { | |
| errorTextElement.textContent = "没有测试点信息"; | |
| } |
1 task
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
fix: reinfo.php shows no test results even if test results are available
Refer to https://support.xmoj-bbs.me/tickets/XS-16/5Zyo5pl55yL5rWL6KV54K56YCa6LH5oOF5Ya15pe25peg5rOV5pi56S65q2j56Gu5oOF5Ya1
How does this PR accomplish the above?:
Improvements to test point information handling:
/reinfo.phppath to ensure proper handling when test point information is available. The code now iterates over elements only if they exist, improving reliability.Enhancements to error message display:
/downloads.phppath to replace the error message<pre id="errtxt" class="alert alert-error">sorry , not available (,,,1)</pre>with a more user-friendly message, "没有测试点信息."By submitting this pull request, I confirm the following:
git rebase)