Skip to content

feat: Enhance keyboard shortcuts for better cross-platform support#808

Merged
boomzero merged 4 commits intodevfrom
boomzero/ctrlkey
Jun 14, 2025
Merged

feat: Enhance keyboard shortcuts for better cross-platform support#808
boomzero merged 4 commits intodevfrom
boomzero/ctrlkey

Conversation

@boomzero
Copy link
Member

@boomzero boomzero commented Jun 14, 2025

What does this PR aim to accomplish?:

This pull request updates keyboard shortcut handling in the XMOJ.user.js script to support both Ctrl and Meta keys for triggering specific actions, improving compatibility across different operating systems.

How does this PR accomplish the above?:

  • Updated the keydown event listener in the DOMContentLoaded handler to trigger the AutoCheatButton click when either Ctrl+Enter or Meta+Enter is pressed.
  • Modified the keydown event listener in int main() to allow SubmitElement to be clicked with either Ctrl+Enter or Meta+Enter. [1] [2]
  • Adjusted the keydown event listener for the ContentEditor to trigger the OKButton click on either Ctrl+Enter or Meta+Enter.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributor's guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented on my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the GNU General Public License v3.0
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request can be closed at the will of the maintainer.
  9. I give this submission freely and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

- Updated keyboard shortcuts to support both `Ctrl` and `Cmd` keys for macOS and Windows/Linux users.
- Improved consistency across multiple event listeners for actions like form submission and button clicks.
@hendragon-bot hendragon-bot bot added the user-script This issue or pull request is related to the main user script label Jun 14, 2025
@boomzero boomzero merged commit fa5a812 into dev Jun 14, 2025
3 checks passed
@boomzero boomzero deleted the boomzero/ctrlkey branch June 14, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S user-script This issue or pull request is related to the main user script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant