Clear session cookie on logout for better security#796
Merged
Conversation
Add a line to remove the PHPSESSID cookie when the user logs out, ensuring the session is properly terminated. This change enhances security by preventing potential session reuse.
8238ec7 to
38c18ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
This pull request introduces a small but important change to the
XMOJ.user.jsscript. It adds functionality to clear a specific cookie (PHPSESSID) when a user logs out.How does this PR accomplish the above?:
XMOJ.user.js: Added a line to delete thePHPSESSIDcookie by setting its expiration date to the past, ensuring the user's session is fully cleared during logout.By submitting this pull request, I confirm the following:
git rebase)