Skip to content

Change how we load addonscript (transition from GitHub pages to Cloudflare KV) + Fix *that* console error#778

Merged
boomzero merged 4 commits intodevfrom
boomzero/addonscript
Feb 10, 2025
Merged

Change how we load addonscript (transition from GitHub pages to Cloudflare KV) + Fix *that* console error#778
boomzero merged 4 commits intodevfrom
boomzero/addonscript

Conversation

@boomzero
Copy link
Member

@boomzero boomzero commented Feb 10, 2025

What does this PR aim to accomplish?:

Change how we load addonscript (transition from GitHub pages to Cloudflare KV) + Fix that console error

How does this PR accomplish the above?:

Error handling improvements:

  • XMOJ.user.js: Removes problematic code that keeps causing console errors.

Script loading updates:

  • AddonScript.js: Added a notice indicating that the file should not be modified and is kept for backward compatibility, along with a warning to update the script.
  • XMOJ.user.js: Replaced the direct fetch and evaluation of AddonScript.js with a call to RequestAPI to fetch the script, improving error handling and logging a warning if fetching fails.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributor's guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented on my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the GNU General Public License v3.0
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request can be closed at the will of the maintainer.
  9. I give this submission freely and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@hendragon-bot hendragon-bot bot added user-script This issue or pull request is related to the main user script addon-script This issue or pull request is related to the addon script labels Feb 10, 2025
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 10, 2025
@github-actions
Copy link
Contributor

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@boomzero boomzero merged commit 34397c7 into dev Feb 10, 2025
3 checks passed
@boomzero boomzero deleted the boomzero/addonscript branch February 10, 2025 11:42
@boomzero
Copy link
Member Author

PS: I think it is because SendData doesn't specify a Callback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addon-script This issue or pull request is related to the addon script size/M user-script This issue or pull request is related to the main user script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant