Conversation
…flare KV) + Fix *that* console error
Contributor
Qodana for JSIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Member
Author
|
PS: I think it is because SendData doesn't specify a Callback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Change how we load addonscript (transition from GitHub pages to Cloudflare KV) + Fix that console error
How does this PR accomplish the above?:
Error handling improvements:
XMOJ.user.js: Removes problematic code that keeps causing console errors.Script loading updates:
AddonScript.js: Added a notice indicating that the file should not be modified and is kept for backward compatibility, along with a warning to update the script.XMOJ.user.js: Replaced the direct fetch and evaluation ofAddonScript.jswith a call toRequestAPIto fetch the script, improving error handling and logging a warning if fetching fails.By submitting this pull request, I confirm the following:
git rebase)