Skip to content

Fix code scanning alert - DOM text reinterpreted as HTML#774

Merged
boomzero merged 3 commits intodevfrom
boomzero/dom-reint
Feb 9, 2025
Merged

Fix code scanning alert - DOM text reinterpreted as HTML#774
boomzero merged 3 commits intodevfrom
boomzero/dom-reint

Conversation

@boomzero
Copy link
Member

@boomzero boomzero commented Feb 9, 2025

What does this PR aim to accomplish?:

Fix code scanning alert - DOM text reinterpreted as HTML

How does this PR accomplish the above?:

  • XMOJ.user.js: Added an escapeHTML function to escape special HTML characters.
  • XMOJ.user.js: Updated the main function to use the escapeHTML function when setting innerHTML to prevent XSS attacks.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributor's guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented on my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the GNU General Public License v3.0
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request can be closed at the will of the maintainer.
  9. I give this submission freely and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@hendragon-bot hendragon-bot bot added the user-script This issue or pull request is related to the main user script label Feb 9, 2025
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 9, 2025
@boomzero boomzero merged commit 233bcb0 into dev Feb 9, 2025
1 check passed
@boomzero boomzero deleted the boomzero/dom-reint branch February 9, 2025 00:15
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M user-script This issue or pull request is related to the main user script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant