Conversation
Collaborator
Author
|
BTW, when I compile on my mac, I get the following warning: This has something to do with the code merged here from |
Member
|
My homebrew clang 15.0.2 doesn't throw that warning, but from a little reading, some compilers (like Mac Developer Tools) have started throwing that warning. Either way, snprintf seems to be C99 compliant, so switching to it shouldn't be a problem. |
jbschroder
reviewed
May 18, 2023
| /* Don't need to update the rhs in the linear case (no Richardson either) */ | ||
| } | ||
| else | ||
| { |
Member
There was a problem hiding this comment.
Should we indent this code block?
jbschroder
reviewed
May 18, 2023
| /* Don't need to update the rhs in the linear case (no Richardson either) */ | ||
| } | ||
| else | ||
| { |
Member
There was a problem hiding this comment.
Should we indent this code block?
Collaborator
Author
There was a problem hiding this comment.
Yes. I wanted the diffs to be clear when I first implemented this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a linear MGRIT implementation to braid. I made it a draft PR because we should change the "switch" to a runtime switch (add a
Setfunction to turn it on/off) and we need to write some brief documentation and probably also a regression test. Otherwise, the code has already been tested thoroughly on thelinearbranch (thislinear-prbranch is the same, but is up to date withmaster)