Return WMarker Term from preprocess#141
Open
jsarabia wants to merge 1 commit intoWycliffeAssociates:masterfrom
Open
Return WMarker Term from preprocess#141jsarabia wants to merge 1 commit intoWycliffeAssociates:masterfrom
jsarabia wants to merge 1 commit intoWycliffeAssociates:masterfrom
Conversation
Returning Term from preprocess allows for the word within a WMarker to be left as remaining text, which will then get picked up into a TextBlock. If this is not done, the word within a WMarker would be ignored when doing something such as getting all TextBlocks from a VMarker, which seems a sensible way to get scripture text without markup from a verse.
rbnswartz
reviewed
Jul 9, 2024
|
|
||
| } | ||
|
|
||
| return string.Empty; |
Member
There was a problem hiding this comment.
We would also need to add TextBlock to allowed markers in order for this to work as expected, otherwise we have a WMarker with the word set and then a text block following it, we would want this to contain that text block. Also if we go down this route I don't think we want to include an attribute for term here, there are others that we do this with we would want to handle those also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning Term from preprocess allows for the word within a WMarker to be left as remaining text, which will then get picked up into a TextBlock.
If this is not done, the word within a WMarker would be ignored when doing something such as getting all TextBlocks from a VMarker, which seems a sensible way to get scripture text without markup from a verse.