Open
Conversation
This updates the `wporg/wporg-mu-plugins` and `wporg/wporg-parent-2021` dependencies in Composer. When running `yarn setup:tools` for the first time, the command will fail due to the pinned commit hashes being removed from the repository. It seems like this can happen through rebases, but it's not clear why this is happening for these two repositories.
Member
Author
|
Looks to also be related to #514. |
This adjusts the `composer install` command in `setup:tools` to include `|| composer update 'wporg/*`. This matches the command used in the GitHub Actions `build.yml` workflow and allows the script to continue when commit SHA values disappear.
Member
Author
|
While working on something else, I noticed that build.yml has the following line: I've added this |
Member
|
Another option is just to delete the composer.lock file..
These hashes will be deleted on every commit to those repo's, as the build branch is rewritten on every merge, as the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
wporg/wporg-mu-pluginsandwporg/wporg-parent-2021dependencies in Composer.When running
yarn setup:toolsfor the first time, the command will fail due to the pinned commit hashes being removed from these repositories.It seems like this can happen through rebases, but it's not clear why this is happening for these two repositories.
This is a more targeted change than #549, which seems to run
composer updatewithout limiting the command to specific dependencies. I am only seeing these two repositories causing failures. The other dependencies should likely be upgraded more intentionally.