Update Setup instructions with prerequisites#516
Open
juanmaguitar wants to merge 1 commit intoWordPress:trunkfrom
Open
Update Setup instructions with prerequisites#516juanmaguitar wants to merge 1 commit intoWordPress:trunkfrom
juanmaguitar wants to merge 1 commit intoWordPress:trunkfrom
Conversation
| "@wordpress/env": "9.2.0" | ||
| }, | ||
| "scripts": { | ||
| "setup:tools": "yarn && composer install && TEXTDOMAIN=wporg composer exec update-configs && composer --working-dir=./source/wp-content/plugins/phpdoc-parser install", |
Contributor
There was a problem hiding this comment.
Not critic, but you would be running this command twice
TEXTDOMAIN=wporg composer exec update-configs
Contributor
Author
There was a problem hiding this comment.
Thanks Carlos!
I'll remove this part from the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
yarn setup:toolsfor the first time after cloning the repo locally, some errors may appear ifcomposer updateis not run first.A specific PHP version is also a requirement that is not properly remarked on the
README.mdSee #514
This PR propose a solution to tackle these issues and improve the contribution experience for first-timers.