Skip to content

escaping functions added and modified in main.php file #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mehrazmorshed wants to merge 2 commits into
base: master
Choose a base branch
from
Open

escaping functions added and modified in main.php file #473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
577571f
escaping functions added and modified in main.php file
mehrazmorshed Oct 27, 2024
41dbceb
modified main.php file
mehrazmorshed Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions main.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function check_main( $theme_slug ) {
}

if ( empty( $theme['Template Version'] ) ) {
echo '<p>' . __( 'Child theme does not have the <strong>Template Version</strong> tag in style.css.', 'theme-check' ) . '</p>';
echo '<p>' . wp_kses_post( __( 'Child theme does not have the <strong>Template Version</strong> tag in style.css.', 'theme-check' ) ) . '</p>';
} elseif ( $theme['Template Version'] < $parent_theme['Version'] ) {
echo '<p>';
printf(
Expand All @@ -97,9 +97,9 @@ function check_main( $theme_slug ) {
$results = display_themechecks();

if ( ! $success ) {
echo '<h2>' . sprintf( __( 'One or more errors were found for %1$s.', 'theme-check' ), esc_html( $theme['Title'] ) ) . '</h2>';
echo '<h2>' . esc_html( sprintf( __( 'One or more errors were found for %1$s.', 'theme-check' ), $theme['Title'] ) ) . '</h2>';
} else {
echo '<h2>' . sprintf( __( '%1$s passed the tests', 'theme-check' ), esc_html( $theme['Title'] ) ) . '</h2>';
echo '<h2>' . esc_html( sprintf( __( '%1$s passed the tests', 'theme-check' ), $theme['Title'] ) ) . '</h2>';
Copy link
Collaborator

@carolinan carolinan Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
It would be better to escape the translated text and the value with esc_html__() inside sprintf().

tc_success();
}

Expand Down