Skip to content

Update /theme-check/checks/class-title-check.php. Validate two text-d… #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
productivemindsdotcom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update /theme-check/checks/class-title-check.php. Validate two text-d… #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 59 additions & 1 deletion checks/class-textdomain-check.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ class TextDomain_Check implements themecheck {
*/
protected $name = '';

/**
* Theme template
*
* @var string $template
*/
protected $template = '';

/**
* Theme slug
*
Expand Down Expand Up @@ -64,6 +71,9 @@ function set_context( $data ) {
if ( isset( $data['theme']['Name'] ) ) {
$this->name = $data['theme']['Name'];
}
if ( isset( $data['theme']['Template'] ) ) {
$this->template = $data['theme']['Template'];
}
if ( isset( $data['slug'] ) ) {
$this->slug = $data['slug'];
}
Expand Down Expand Up @@ -198,6 +208,44 @@ function check( $php_files, $css_files, $other_files ) {
$domains = array_unique( $domains );
$domainlist = implode( ', ', $domains );
$domainscount = count( $domains );

$this_name = sanitize_title_with_dashes( $this->name );
$this_template = sanitize_title_with_dashes( $this->template );

$get_stylesheet = get_stylesheet();
$get_stylesheet = sanitize_title_with_dashes( $get_stylesheet );

$get_template = get_template();
$get_template = sanitize_title_with_dashes( $get_template );

$wp_get_theme = wp_get_theme();
$wp_get_theme_template = sanitize_title_with_dashes( $wp_get_theme['Template'] );

$is_theme_confirmed = $this_name == $get_stylesheet;
$is_template_confirmed = ($this_template == $get_template) && ($this_template == $wp_get_theme_template);

$is_child_and_parent_theme_count = 0;
$is_valid_child_and_parent_theme = false;
if( ( !empty($this_name) && !empty($this_template) ) &&
( $this_name != $this_template ) &&
( 2 == $domainscount ) &&
( $is_theme_confirmed && $is_template_confirmed ) )
{
// If we get here, this is likely a child theme, along with corresponding parent theme
foreach ( $domains as $domain ) {
$domain_sanitized = sanitize_title_with_dashes( $domain );
if( $this_name == $domain_sanitized ) {
$is_child_and_parent_theme_count += 1;
}
if( $this_template == $domain_sanitized ) {
$is_child_and_parent_theme_count += 1;
}
}
if( 2 == $is_child_and_parent_theme_count ) {
// If we get here, this is definitely a child theme, along with corresponding parent theme
$is_valid_child_and_parent_theme = true;
}
}

// ignore core themes and uploads on w.org for this one check
if ( ! in_array( $this->slug, $this->exceptions ) && ! $this->is_wporg ) {
Expand Down Expand Up @@ -229,7 +277,17 @@ function check( $php_files, $css_files, $other_files ) {
}
}

if ( $domainscount > 1 ) {
if ( $is_valid_child_and_parent_theme ) {
$this->error[] = sprintf(
'<span class="tc-lead tc-info">%s</span>: %s %s',
__( 'INFO', 'theme-check' ),
__( "This theme uses two text domains: one for the child theme and another for the parent theme. Ensure that these two text domains correctly match the slugs of the respective parent and child themes. Correctly aligning both slugs is essential for compatibility with WordPress.org language packs.", 'theme-check' ),
sprintf(
__( 'The domains found are: %s.', 'theme-check' ),
'<strong>' . $domainlist . '</strong>'
)
);
} else if ( $domainscount > 1 ) {
$this->error[] = sprintf(
'<span class="tc-lead tc-warning">%s</span>: %s %s',
__( 'WARNING', 'theme-check' ),
Expand Down