Create helper function for parsing runner configuration environment variables #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces `setup_runner_env_vars()` to process environment variables used to configure the test runner to avoid repeated code.
This switches to handling debug mode as a boolean matching truthy values, which simplifies things.
Co-Authored-By: Javier Casares <javier@casares.org>
When this is not defined at all, assume a misconfiguration and verify certificates.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
kittenkamala
approved these changes
Sep 3, 2025
Crixu
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
setup_runner_env_vars()function, which processes all runner-related environment variables that are used in multiple scripts (prepare.php,test.php, etc.).There are also some new default values being added for when certain environment variables are missing entirely. These new default values were initially added in #212, but they are being split out for separate consideration. This PR expands on the commit that introduced defaults a bit by also refining the expected/actual data types.
Other notes:
WPT_DEBUGhas changed from expecting a falsey value orverboseto expecting a falsey or truthy value. This should preserve the current behavior while making it more closely match Core, and be easier to understand as an on/off switch.WPT_CERTIFICATE_VALIDATIONwill now default totruewhen not set at all. This guards against a misconfiguration accidentally leaving the script potentially vulnerable.WPT_SSH_PRIVATE_KEY_BASE64was left out of the function to avoid unintentionally exposing the value in the test, report, or cleanup scripts.