Open
Conversation
Fixes errors for nikic/php-parser v1.2.0+ by checking the property. See issue WordPress#206
Installs the latest WP version Installs the compatible PHPUnit version depending on PHP version.
ntwb
approved these changes
Jan 31, 2019
Member
ntwb
left a comment
ntwb
left a comment
There was a problem hiding this comment.
Looks good to me, just one nit, the addition of a PHP 7.2 job please 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The (travis-ci) unit tests are failing because not all PHPUnit versions are compatible with the
WP_UnitTestCaseclass from WordPress.This pull requests replaces the hard coded WP version (4.3) with the latest WP version by calling the WordPress API. It then installs the correct PHPUnit version depending on the PHP version. PHPUnit 7 is not yet supported. See ticket #43218.
The errors discussed in issue #206 are because the nikic/php-parser v1.2.0+ doesn't use magic getters anymore. This is fixed by checking if the property exist before referencing it.
This PR also removes testing for
hhvmas that's no longer needed in my opinion.