Block visibility badge: use canvas iframe for viewport detection#76889
Open
Block visibility badge: use canvas iframe for viewport detection#76889
Conversation
The inspector badge was measuring viewport width against the outer browser window instead of the canvas iframe. Pass the iframe window to useBlockVisibility so the badge matches actual block rendering. Fixes #76730
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
[Feature] Design Tools
6 tasks
|
Size Change: +28 B (0%) Total Size: 7.73 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e798ec7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23704643728
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #76730
The hidden block badge in the inspector sidebar was using the browser window width to detect the current viewport. But blocks in the canvas use the iframe window width. When the browser window is narrow, the badge could say "Block is hidden on Desktop" even though the canvas is rendering at a different size.
This passes the canvas iframe's window to
useBlockVisibilityviauseBlockElement, matching whatuse-block-propsandblock-list/block.jsalready do.Test plan
Cmd + +).Kapture.2026-03-29.at.17.08.51.mp4