Block Fields: Use the LinkPicker component for links#76880
Draft
Block Fields: Use the LinkPicker component for links#76880
Conversation
…call are respected in setBoundAttributes
talldan
added
[Type] Enhancement
github-actions
bot
added
[Package] Editor
|
Size Change: +135 B (0%) Total Size: 7.73 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0f831c6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23680772405
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes part of #74797
Updates Block Fields to use the LinkPicker component and support the Navigation Link block's binding behavior.
I think after this there are a few tasks to achieve parity with the nav block's own controls:
How?
LinkPickerkind,type,id, andbindingsattributes available to the LinkField (via getValue/setValue)setAttributesto update bindings in the same phase as making changes to bound attributes (e.g. removing the block bindings from an attribute and also setting the attribute to a different value). I'll split this change to a separate PR.Testing Instructions
Screenshots or screencast
Use of AI Tools