Skip to content

Fix color palette dropdown not closing on custom color selection#74173

Closed
iqbal-web wants to merge 1 commit intoWordPress:trunkfrom
iqbal-web:#74154-Selecting-Color-Palette-Dropdown
Closed

Fix color palette dropdown not closing on custom color selection#74173
iqbal-web wants to merge 1 commit intoWordPress:trunkfrom
iqbal-web:#74154-Selecting-Color-Palette-Dropdown

Conversation

@iqbal-web
Copy link
Copy Markdown

@iqbal-web iqbal-web commented Dec 22, 2025

What?

Fixed #74154

Why?

Selecting a custom color might prevent the color palette from closing.

How?

  • Updated renderContent to receive and pass the onClose callback to ColorGradientControl
  • Added onClose parameter to ColorGradientControlInner function
  • Updated both color and gradient onChange handlers to call onClose?.() after setting the new value

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before After

@iqbal-web iqbal-web requested a review from ellatrix as a code owner December 22, 2025 16:58
@github-actions github-actions bot added the [Package] Block editor /packages/block-editor label Dec 22, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 22, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: iqbal-web <iqbal1hossain@git.wordpress.org>
Co-authored-by: SirLouen <sirlouen@git.wordpress.org>
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @iqbal-web! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 22, 2025
@t-hamano t-hamano added the [Type] Bug An existing feature does not function as intended label Dec 23, 2025
@SirLouen
Copy link
Copy Markdown
Member

This seems to be a close candidate. It seems you are patching the problem, but not addressing the underlying issue.

I'm going to leave it open for now, but this might close in favor to #74179

cc @t-hamano

@SirLouen
Copy link
Copy Markdown
Member

SirLouen commented Jan 6, 2026

This is not going to happen. Closing.

@SirLouen SirLouen closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selecting a custom color might prevent the color palette from closing.

3 participants