-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Block API: Fallback to all attributes when checking for unmodified block #73867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,20 +43,27 @@ export function isUnmodifiedBlock( block, role ) { | |
| const blockAttributes = getBlockType( block.name )?.attributes ?? {}; | ||
|
|
||
| // Filter attributes by role if a role is provided. | ||
| const attributesToCheck = role | ||
| const attributesByRole = role | ||
| ? Object.entries( blockAttributes ).filter( ( [ key, definition ] ) => { | ||
| // A special case for the metadata attribute. | ||
| // It can include block bindings that serve as a source of content, | ||
| // without directly modifying content attributes. | ||
| if ( role === 'content' && key === 'metadata' ) { | ||
| return true; | ||
| return ( | ||
| Object.keys( block.attributes[ key ]?.bindings ?? {} ) | ||
| .length > 0 | ||
| ); | ||
|
Comment on lines
+52
to
+55
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I skipped on this idea originally, but it became an obvious choice when working on this fix. Otherwise, the fallback doesn't work. |
||
| } | ||
|
|
||
| return ( | ||
| definition.role === role || | ||
| definition.__experimentalRole === role | ||
| ); | ||
| } ) | ||
| : []; | ||
| // Fallback to all attributes if no attributes match the role. | ||
| const attributesToCheck = !! attributesByRole.length | ||
| ? attributesByRole | ||
| : Object.entries( blockAttributes ); | ||
|
|
||
| return attributesToCheck.every( ( [ key, definition ] ) => { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.