Skip to content

Accordion Heading: Add default style for classic themes #73608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 3 commits into from
Nov 28, 2025
+40 −30
Merged

Accordion Heading: Add default style for classic themes #73608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b02049
Accordion Heading: Add default style for classic themes
t-hamano Nov 26, 2025
872281d
Merge branch 'trunk' into accordion-heading-classic-style
t-hamano Nov 28, 2025
67bd825
Revert unnecessary changes
t-hamano Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 2 additions & 30 deletions packages/block-library/src/accordion-heading/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
.wp-block-accordion-heading {
// Some classic themes apply default margins to heading elements,
// so those styles need to be reset.
margin: 0;
}

.wp-block-accordion-heading__toggle {
font-family: inherit;
font-size: inherit;
Expand All @@ -14,7 +8,9 @@
text-decoration: inherit;
word-spacing: inherit;
font-style: inherit;
background: none;
border: none;
color: inherit;
padding: var(--wp--preset--spacing--20, 1em) 0;
cursor: pointer;
overflow: hidden;
Expand All @@ -23,34 +19,10 @@
text-align: inherit;
width: 100%;

// Some themes may apply colors to button elements with a particularly
// high CSS specificity. Since it's impossible to predict this specificity,
// we reset the colors using `!important`.
background-color: inherit !important;
color: inherit !important;

&:not(:focus-visible) {
outline: none;
}

&:hover,
&:focus {
// Some themes may apply styles when a button element is hovered
// over or focused. This is not intended for accordion toggle
// buttons, so we reset it here.
text-decoration: none;
background-color: inherit !important;
box-shadow: none;
color: inherit;
border: none;
padding: var(--wp--preset--spacing--20, 1em) 0;
}

&:focus-visible {
outline: auto;
outline-offset: 0;
}

&:hover .wp-block-accordion-heading__toggle-title {
text-decoration: underline;
}
Expand Down
38 changes: 38 additions & 0 deletions packages/block-library/src/classic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,41 @@
background: #32373c;
color: $white;
}

// These rules are needed to enforce the default styling of
// the Accordion Heading block in the classic theme.
.wp-block-accordion-heading {
// Heading elements may have default margins applied, so those
// styles need to be reset.
margin: 0;
}

.wp-block-accordion-heading__toggle {
// Button elements can have colors applied with high CSS specificity,
// and since this specificity is impossible to predict, we use
// `!important` to reset the color.
background-color: inherit !important;
color: inherit !important;

&:not(:focus-visible) {
outline: none;
}

&:hover,
&:focus {
// Sometimes styles are applied when the button element is
// hovered over or focused. This isn't expected for accordion
// toggle buttons, so reset those styles here.
text-decoration: none;
background-color: inherit !important;
box-shadow: none;
color: inherit;
border: none;
padding: var(--wp--preset--spacing--20, 1em) 0;
}

&:focus-visible {
outline-offset: 0;
outline: auto;
}
}
Loading