Use Clortho to securely save credentials for patch uploads#40
Open
morganestes wants to merge 2 commits intoWordPress:trunkfrom
Open
Use Clortho to securely save credentials for patch uploads#40morganestes wants to merge 2 commits intoWordPress:trunkfrom
morganestes wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Uses the Clortho NPM package to securely save username and password for authentication when uploading patches. If a username doesn't have a password saved, it will prompt to save it using either native dialog boxes, or the CLI. Afterwards, the user will be prompted for a WP.org username, and the saved password will be automatically used without further prompting.
Member
|
😍 Thanks @morganestes |
Author
|
Just on macOS for now. I need to install a Windows VM to test it there, and
I can test Linux inside VVV.
|
Member
|
https://www.npmjs.com/package/keytar seems like it might be a better choice since it's actively developed while Clortho seems to be somewhat forgoten. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a patch is uploaded, the user is prompted for the username and password each time before uploading to a ticket. This will save the credentials in the system store and only prompt for the username for each upload.
Alternatively, we could store the username in a config file and not prompt for it each time, but asking for it each time probably isn't that horrible.
See #37.