Skip to content

Prevent TreeGroup buttons being broken somehow #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nevcairiel merged 4 commits into from
Dec 5, 2024
Merged

Prevent TreeGroup buttons being broken somehow #23

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dcaffd
Prevent TreeGroup buttons being broken somehow
Justw8 Dec 3, 2024
efc312b
Add Comment
Justw8 Dec 3, 2024
7b73b9a
Use buttonnum for the loop to hide
Justw8 Dec 4, 2024
e81693f
update comment
Justw8 Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions AceGUI-3.0/widgets/AceGUIContainer-TreeGroup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
TreeGroup Container
Container that uses a tree control to switch between groups.
-------------------------------------------------------------------------------]]
local Type, Version = "TreeGroup", 47
local Type, Version = "TreeGroup", 48
local AceGUI = LibStub and LibStub("AceGUI-3.0", true)
if not AceGUI or (AceGUI:GetWidgetVersion(Type) or 0) >= Version then return end

Expand Down Expand Up @@ -387,10 +387,6 @@ local methods = {
["RefreshTree"] = function(self,scrollToSelection,fromOnUpdate)
local buttons = self.buttons
local lines = self.lines

for i, v in ipairs(buttons) do
v:Hide()
end
while lines[1] do
local t = tremove(lines)
for k in pairs(t) do
Expand Down Expand Up @@ -499,6 +495,10 @@ local methods = {
buttonnum = buttonnum + 1
end

-- We hide the remaining buttons after updating others to avoid a blizzard bug that keeps them interactable even if hidden when hidden before updating the buttons.
for i = buttonnum, #buttons do
buttons[i]:Hide()
end
end,

["SetSelected"] = function(self, value)
Expand Down
Loading