Potential Fix: lockups with HD Audio controller#155
Open
EDEADLINK wants to merge 1 commit intoWitko:masterfrom
Open
Potential Fix: lockups with HD Audio controller#155EDEADLINK wants to merge 1 commit intoWitko:masterfrom
EDEADLINK wants to merge 1 commit intoWitko:masterfrom
Conversation
Turning the PCIe controller on before the HD audio controller is turned on can lead to hung tee processes, hung kernel tasks and other badness. If HDA_CONTROLLER_BUS_ID is set we can turn the HD Audio Controller on before the PCIe controller is turned on. This can cause a PCI error: >can't change power state from D3cold to D0 (config space inaccessible) But that's better than hanging the system. When turning off the card the order doesn't seem to matter. But we do turn on Powersave for the HDA controller again, as the nvidia card can't fully power off otherwise.
Author
|
The behaviour is currently optional and only documented in the config. If this is works on other machines we should document it in the README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turning the PCIe controller on before the HD audio controller is turned on
can lead to a hung tee processes, hung kernel tasks and other badness.
This introduces HDA_CONTROLLER_BUS_ID to the config
which if set will turn HD Audio Controller on
before the PCIe controller is turned on.
While this can cause a PCI error:
that's a lot better than hanging the system.
When turning off the cards the order doesn't seem to matter,
but we do need to turn Powersave for Both so that the card
actually turns off (Powertop reports ~10 Watts less draw).
I have no Idea why this works.
So I can't say for certain that it works.
But It could be the fix for a few of the issues mentioned in #137
If you have similar hangs please test this.
Especially if you get something similar to me in
lspci -tvvor
lspci