Do not append CWD to (empty) LD_LIBRARY_PATH#146
Open
resilar wants to merge 1 commit intoWitko:masterfrom
resilar:master
Open
Do not append CWD to (empty) LD_LIBRARY_PATH#146resilar wants to merge 1 commit intoWitko:masterfrom resilar:master
resilar wants to merge 1 commit intoWitko:masterfrom
resilar:master
Conversation
If LD_LIBRARY_PATH is unset, nvidia-xinitrc exports LD_LIBRARY_PATH with
a trailing colon (':') which is interpreted as an empty path, i.e., the
current working directory (CWD). This creates a security vulnerability
known as "Uncontrolled Search Path Element" (CWE-427). The commit avoids
appending a trailing colon if LD_LIBRARY_PATH is empty.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If LD_LIBRARY_PATH is unset, nvidia-xinitrc exports LD_LIBRARY_PATH with
a trailing colon (':') which is interpreted as an empty path, i.e., the
current working directory (CWD). This creates a security vulnerability
known as "Uncontrolled Search Path Element" (CWE-427). The commit avoids
appending a trailing colon if LD_LIBRARY_PATH is empty.