refactor: rename *Manager types to domain-role names (#520)#623
Open
refactor: rename *Manager types to domain-role names (#520)#623
Conversation
Four types used the vague Manager suffix, violating the Code Naming Contract. Renamed to reflect their domain roles: - SessionManager → DaemonSessionStore (kild-daemon) - PtyManager → PtyStore (kild-daemon) - ProjectManager → ProjectRegistry (kild-core) - TeamManager → TeamStore (kild-ui) Also renamed the pty_manager field to pty_store in DaemonSessionStore for consistency, and updated all doc comments and documentation. Fixes #520
Owner
Author
Automated Code ReviewSummaryClean mechanical rename of 4 types across 18 files with no behavior changes. All usages covered, all tests pass. FindingsStrengths
Suggestions (non-blocking)
Security
Checklist
Self-reviewed by Claude |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four types used the vague
Managersuffix, violating the Code Naming Contract which requires types to reflect domain role. Renamed all four to descriptive domain-role names:SessionManagerDaemonSessionStorePtyManagerPtyStoreProjectManagerProjectRegistryTeamManagerTeamStoreAlso renamed the
pty_managerfield →pty_storeinDaemonSessionStoreand updated all doc comments + CLAUDE.md/AGENTS.md references.Pure rename — no behavior changes.
Testing
cargo fmt --check— 0 violationscargo clippy --all -- -D warnings— 0 warningscargo test --all— all passValidation
Issue
Fixes #520